Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 445784 - x11-misc/virtualgl: please stop subshelling randomly for multilib
Summary: x11-misc/virtualgl: please stop subshelling randomly for multilib
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal major (vote)
Assignee: Pacho Ramos
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-03 12:01 UTC by Michał Górny
Modified: 2013-05-09 22:08 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2012-12-03 12:01:27 UTC
The subshells in x11-misc/virtualgl are crazy and broke the BUILD_DIR backwards compatibility code. Therefore, I migrated the package directly.

Anyway, please stop doing that. If you want to keep the 32-bit variables local-local, please put them into a separate function. And please consider using multilib_toolchain_setup instead of hand-defining variables.

For proper examples of multilib, please see libtxc_dxtn (the older ebuild defines stuff directly).
Comment 1 Pacho Ramos gentoo-dev 2013-02-05 17:39:31 UTC
Looks like there is an eclass for autotools multilib stuff, how will other build systems be handled? Via multilib-ebuild.eclass? 

Thanks for the info :)
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-02-05 17:50:22 UTC
(In reply to comment #1)
> Looks like there is an eclass for autotools multilib stuff, how will other
> build systems be handled? Via multilib-ebuild.eclass? 
> 
> Thanks for the info :)

Well, I'd say cmake-multilib.eclass won't hurt. 'Multilibization' of out-of-source builds is awesome easy. Well, unless this ain't an out-of-source build.
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-02-05 20:22:15 UTC
For the new eclass & ebuild:

http://thread.gmane.org/gmane.linux.gentoo.devel/83585

Please note that I have assumed that 'fakelib' subdirectory name is irrelevant and just thrown a quick ${ABI} there :).
Comment 4 Pacho Ramos gentoo-dev 2013-02-05 20:26:28 UTC
Thanks a lot for your work :)
Comment 5 Pacho Ramos gentoo-dev 2013-05-09 22:08:37 UTC
+*virtualgl-2.3.2-r1 (09 May 2013)
+
+  09 May 2013; Pacho Ramos <pacho@gentoo.org> +virtualgl-2.3.2-r1.ebuild:
+  Build multilib properly (#445784 by mgorny)
+