445718 – flag-o-matic improperly strips -mfloat-abi=hard

Bug 445718 - flag-o-matic improperly strips -mfloat-abi=hard

Summary: flag-o-matic improperly strips -mfloat-abi=hard

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Eclasses (show other bugs)
Hardware:	ARM Linux

Importance:	Normal major (vote)
Assignee:	Gentoo Toolchain Maintainers

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2012-12-02 22:42 UTC by Rick Farina (Zero_Chaos)
Modified:	2012-12-03 21:20 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Rick Farina (Zero_Chaos) gentoo-dev

2012-12-02 22:42:08 UTC

In flag-o-matic we see -mfloat-abi=* defined in ALLOWED_FLAGS on line 48.

However, strip-flags messes with the flags on line 364 local flag=${x%%=*} which then causes -mfloat-abi=hard to be compared as -mfloat-abi which doesn't match -mfloat-abi=* .

Solution it to change line 48 and remove the "=*".

Comment 1 Rick Farina (Zero_Chaos) gentoo-dev

2012-12-02 22:43:09 UTC

I honestly have no idea how the arm7a_hardfloat stages get built as this completely prevents my bootstrapping a prefix since it keeps dropping hardfloat from my cflags.

Comment 2 SpanKY gentoo-dev

2012-12-03 21:20:56 UTC

(In reply to comment #0)

http://sources.gentoo.org/eclass/flag-o-matic.eclass?r1=1.184&r2=1.185

(In reply to comment #1)

as announced quite a while ago, armv[67]* gcc defaults to hardfloat