Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 445380 - sys-apps/portage : repoman should not commit when ECHANGELOG_USER is empty
Summary: sys-apps/portage : repoman should not commit when ECHANGELOG_USER is empty
Status: RESOLVED WONTFIX
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-30 19:30 UTC by Agostino Sarubbo
Modified: 2022-07-12 03:18 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2012-11-30 19:30:51 UTC
Would be great if repoman does not commit when ECHANGELOG_USER variable is empty. Also, it should suggest how to set it.
Comment 1 Zac Medico gentoo-dev 2012-12-01 21:39:25 UTC
I'm pretty sure the current code is compatible with echangelog, so if we change something then we should probably change both.

I happen to use 'zmedico' as my login on all of my computers, so the current behavior works nicely for me, since I don't have to set the ECHANGELOG_USER variable.
Comment 2 Göktürk Yüksek archtester gentoo-dev 2016-04-11 05:06:26 UTC
I believe this bug is obsolete now.
Comment 3 Arfrever Frehtes Taifersar Arahesis 2016-04-11 06:45:21 UTC
Generally bugs in code for generation of entries in ChangeLogs could still be fixed for convenience of repositories other than repository "gentoo" and having VCS-tracked ChangeLogs.

Current code:
https://gitweb.gentoo.org/proj/portage.git/tree/pym/repoman/utilities.py?id=aa7558a93d42d73ad916eecd2c3e8c6c294fe735#n358 :
		pwd_struct = pwd.getpwuid(os.getuid())
		gecos = pwd_struct.pw_gecos.split(',')[0]  # bug #80011
		user = '%s <%s@gentoo.org>' % (gecos, pwd_struct.pw_name)

I would rather suggest to drop assumption of @gentoo.org e-mail address.


Or whole code for handling of ChangeLogs in repoman could be dropped...
Comment 4 SpanKY gentoo-dev 2016-04-15 02:58:57 UTC
(In reply to Arfrever Frehtes Taifersar Arahesis from comment #3)

imo, we should drop all the changelog code.  the majority of our devs/users don't use it anymore which means it's just rotting/wasting our time maintaining it.
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-12 03:18:32 UTC
repoman support has been removed per bug 835013.

Please file a new bug (or, I suppose, reopen this one) if you feel this check is still applicable to pkgcheck and doesn't already exist.