Bug 444538 – devmanual tells people to always set IUSE, while PMS not

• Status: RESOLVED FIXED
• Product: Documentation

[Description Pacho Ramos 2012-11-24 09:14:09 UTC]

Per:
http://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html
http://devmanual.gentoo.org/ebuild-writing/variables/index.html#iuse

people is mandated to always set IUSE, but looks like this was changed in:
http://permalink.gmane.org/gmane.linux.gentoo.pms/1

but I am not sure if I have properly interpreted it :|

Reproducible: Always

[Comment 1 Markos Chandras (RETIRED) 2012-11-24 10:02:30 UTC]

Oops I was not aware of that

[Comment 2 Markos Chandras (RETIRED) 2012-11-24 10:24:55 UTC]

CC'ing Ulrich in case he still have that patch around.

[Comment 3 Ulrich Müller 2012-11-24 13:12:17 UTC]

It was discussed here: <http://thread.gmane.org/gmane.linux.gentoo.devel/78806>
Conclusion was that requiring empty assignments is pointless.

I've fixed it in the "Variables" section: <http://git.overlays.gentoo.org/gitweb/?p=proj/devmanual.git;a=commit;h=e63f7a8e09f43c3c5e2dba04a47453f22775fa1b> but looks like I've missed the places where is warns about unset IUSE.

(In reply to comment #0)
> http://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html

I suggest to remove the "IUSE Missing" section.

> http://devmanual.gentoo.org/ebuild-writing/variables/index.html#iuse

Maybe the note should be changed to "You need not assign the IUSE variable in your ebuild if it is empty." and downgraded from <important> to <note>.

[Comment 4 Ulrich Müller 2012-11-24 13:41:10 UTC]

While we are at it: "Also note that it's really really broken in portage versions before 2.0.51." certainly isn't needed any longer?

[Comment 5 Markos Chandras (RETIRED) 2012-11-24 14:17:49 UTC]

(In reply to comment #3)
> It was discussed here:
> <http://thread.gmane.org/gmane.linux.gentoo.devel/78806>
> Conclusion was that requiring empty assignments is pointless.
> 
> I've fixed it in the "Variables" section:
> <http://git.overlays.gentoo.org/gitweb/?p=proj/devmanual.git;a=commit;
> h=e63f7a8e09f43c3c5e2dba04a47453f22775fa1b> but looks like I've missed the
> places where is warns about unset IUSE.
> 
> (In reply to comment #0)
> > http://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html
> 
> I suggest to remove the "IUSE Missing" section.
> 
> > http://devmanual.gentoo.org/ebuild-writing/variables/index.html#iuse
> 
> Maybe the note should be changed to "You need not assign the IUSE variable
> in your ebuild if it is empty." and downgraded from <important> to <note>.

agreed

[Comment 6 Markos Chandras (RETIRED) 2012-11-24 14:18:27 UTC]

(In reply to comment #4)
> While we are at it: "Also note that it's really really broken in portage
> versions before 2.0.51." certainly isn't needed any longer?

yeah I guess so

[Comment 7 Ulrich Müller 2012-11-24 14:53:04 UTC]

Created attachment 330454 [details, diff]
0001-ebuild-writing-variables-Remove-obsolete-note-about-.patch

[Comment 8 Ulrich Müller 2012-11-24 14:53:42 UTC]

Created attachment 330456 [details, diff]
0002-Don-t-say-that-IUSE-must-be-always-assigned-bug-4445.patch

Please review.

[Comment 9 Markos Chandras (RETIRED) 2012-11-24 19:00:23 UTC]

Patches look good. Please commit them :)

[Comment 10 Ulrich Müller 2012-11-24 19:16:11 UTC]

Pushed. Closing.