Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 444286 - media-plugins/qmmp-plugin-pack missing some depend/rdepend
Summary: media-plugins/qmmp-plugin-pack missing some depend/rdepend
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Markos Chandras (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-22 11:29 UTC by Agostino Sarubbo
Modified: 2012-12-08 21:58 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild-patch (diff,686 bytes, text/plain)
2012-11-25 13:57 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2012-11-22 11:29:36 UTC
the ebuild needs yams as depend.

the ebuild needs CMAKE_MIN_VERSION

the ebuild need media-sound/mpg123 as rdepend


this is the complete rdep list:

media-libs/taglib-1.7.2
media-sound/mpg123-1.14.2
media-sound/qmmp-0.6.0
x11-libs/qt-core-4.8.2
x11-libs/qt-gui-4.8.2

I know most are pulled in by qmmp, but they don't specify the version at all.

Please say ack and I will fix by myself.
Comment 1 Markos Chandras (RETIRED) gentoo-dev 2012-11-22 12:19:34 UTC
Adding a version in the qt-* modules is not needed. The latest stable is in the 4.8 series anyway. Also a slot is missing in the qt-* modules. I can't check for the others
Comment 2 Markos Chandras (RETIRED) gentoo-dev 2012-11-25 13:43:48 UTC
Please post a diff here for review and then you can commit it ;)
Comment 3 Agostino Sarubbo gentoo-dev 2012-11-25 13:57:17 UTC
Created attachment 330540 [details]
ebuild-patch
Comment 4 Markos Chandras (RETIRED) gentoo-dev 2012-11-26 09:43:58 UTC
Please drop the version for qt-gui. The older we have is 4.7.4. Otherwise looks good so when you fix the qt-gui issue, go ahead an commit it
Comment 5 Agostino Sarubbo gentoo-dev 2012-11-26 09:58:45 UTC
(In reply to comment #4)
> Please drop the version for qt-gui. The older we have is 4.7.4. Otherwise
> looks good so when you fix the qt-gui issue, go ahead an commit it

what happens if, e.g. I have an old system with qt-4.5 ?
Comment 6 Markos Chandras (RETIRED) gentoo-dev 2012-11-26 10:06:51 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > Please drop the version for qt-gui. The older we have is 4.7.4. Otherwise
> > looks good so when you fix the qt-gui issue, go ahead an commit it
> 
> what happens if, e.g. I have an old system with qt-4.5 ?

Err we must not care. We can't support old versions forever. We never do that for any package.
Comment 7 Markos Chandras (RETIRED) gentoo-dev 2012-12-08 21:58:58 UTC
Fixed in 0.6.3

+*qmmp-plugin-pack-0.6.3 (08 Dec 2012)
+
+  08 Dec 2012; Markos Chandras <hwoarang@gentoo.org>
+  +qmmp-plugin-pack-0.6.3.ebuild:
+  Version bump. Fix dependencies. Bug #444286 thanks to Agostino Sarubbo
+  <ago@gentoo.org>
+