Portage 2.2.0_alpha142 (default/linux/amd64/10.0, gcc-4.7.2-asneeded, glibc-2.16.0, 3.4.7-hardened x86_64) ================================================================= System uname: Linux-3.4.7-hardened-x86_64-AMD_Opteron-TM-_Processor_6272-with-gentoo-2.2 Timestamp of tree: Sat, 03 Nov 2012 05:00:01 +0000 ld GNU ld (GNU Binutils) 2.23 ccache version 3.1.8 [disabled] app-shells/bash: 4.2_p39 dev-java/java-config: 2.1.12 dev-lang/python: 2.6.8, 2.7.3-r2, 3.2.3-r1 dev-util/ccache: 3.1.8 dev-util/cmake: 2.8.9-r1 dev-util/pkgconfig: 0.27.1 sys-apps/baselayout: 2.2 sys-apps/openrc: 0.11.2 sys-apps/sandbox: 2.6 sys-devel/autoconf: 2.13, 2.69 sys-devel/automake: 1.4_p6-r1, 1.9.6-r3, 1.10.3, 1.11.6, 1.12.4 sys-devel/binutils: 2.23 sys-devel/gcc: 4.6.3, 4.7.2 sys-devel/gcc-config: 1.7.3 sys-devel/libtool: 2.4.2 sys-devel/make: 3.82-r4 sys-kernel/linux-headers: 3.6 (virtual/os-headers) sys-libs/glibc: 2.16.0 Repositories: gentoo tbamd64 ACCEPT_KEYWORDS="amd64 ~amd64" ACCEPT_LICENSE="*" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-O2 -pipe -ggdb -march=native -ftracer -frecord-gcc-switches" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /etc/entropy /opt/openjms/config /usr/share/bufrtables /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/maven-bin-3.0/conf /usr/share/openvpn/easy-rsa /usr/share/qpsmtpd/plugins /usr/share/themes/oxygen-gtk/gtk-2.0 /var/bind /var/lib/hsqldb /var/lib/redmine/config /var/spool/torque /var/yp/Makefile" CONFIG_PROTECT_MASK="${EPREFIX}/etc/gconf /etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/games/angband/edit/ /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/splash /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c /var/lib/redmine/config/locales /var/lib/redmine/config/settings.yml" CXXFLAGS="-O2 -pipe -ggdb -march=native -ftracer -frecord-gcc-switches" DISTDIR="/var/cache/portage/distfiles" FCFLAGS="-O2 -pipe -ggdb -march=native -frecord-gcc-switches" FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fail-clean fixlafiles merge-sync news parallel-fetch protect-owned sandbox sfperms strict test test-fail-continue unknown-features-warn unmerge-orphans userfetch userpriv usersandbox" FFLAGS="-O2 -pipe -ggdb -march=native -frecord-gcc-switches" GENTOO_MIRRORS="http://ftp.ucsb.edu/pub/mirrors/linux/gentoo/ http://gentoo.mirrors.hoobly.com/ http://gentoo.llarian.net/" LANG="en_US.utf8" LC_ALL="C" LDFLAGS="-Wl,-O1 -Wl,--as-needed" MAKEOPTS="-j24" PKGDIR="/usr/portage/packages" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages" PORTAGE_TMPDIR="/tmp" PORTDIR="/var/cache/tinderbox/tree" PORTDIR_OVERLAY="/root/overlay" SYNC="rsync://rsync.gentoo.org/gentoo-portage" USE="3dnow 3dnowex acl amd64 berkdb bzip2 cli cracklib crypt cups cxx dri emacs ffmpeg fortran gdbm gnutls gpm iconv icu intl ipv6 mmx modules mudflap multilib ncurses nls nptl openmp pam pax_kernel pcre pdf plasma pppd qt3support readline semantic-desktop session snmp sse sse2 sse3 sse4 ssl ssse3 tcmalloc tcpd udev unicode vhosts zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" PHP_TARGETS="php5-3" PYTHON_TARGETS="python3_2 python2_7" RUBY_TARGETS="ruby18 ruby19 ree18" USERLAND="GNU" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LINGUAS, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
Could you also attach the file with more details? obj/so/test/filtered_re2_test FAIL; output in obj/so/test/filtered_re2_test.log obj/so/test/mimics_pcre_test FAIL; output in obj/so/test/filtered_re2_test.log I know this was filed in an automated way, so the script had no way to check for that. That's fine. If you have an idea how to possibly handle this better ebuild-side, I'm interested.
How long are the files?
(In reply to comment #2) > How long are the files? Very short. Pasting contents inline (I somehow reproduced): re2/prefilter_tree.cc:288: Compile() not called re2/testing/filtered_re2_test.cc:35: Check failed: (0) == (v.atoms.size()) FilteredRE2Test.EmptyTest FilteredRE2Test.SmallOrTest
My current suspicion: running make shared-tests vs. make test which upstream is using.
When these lines removed from ebuild - all tests passed. So, patch is broken. # Fix problems with FilteredRE2 symbols not being exported. epatch "${FILESDIR}/${PN}-symbols-r0.patch"
(In reply to comment #5) > When these lines removed from ebuild - all tests passed. So, patch is broken. > > # Fix problems with FilteredRE2 symbols not being exported. > epatch "${FILESDIR}/${PN}-symbols-r0.patch" I don't think it's broken, I think the lack of it is just covering up the problem, although I'm not quite sure how. The first thing to note is that the tests, when built for the "shared-test" mode, are linked to both the shared and the static version of the library: obj/so/test/%: obj/so/libre2.so obj/libre2.a obj/so/re2/testing/%.o $(STESTOFILES) obj/so/util/test.o @mkdir -p obj/so/test $(CXX) -o $@ obj/so/re2/testing/$*.o $(STESTOFILES) obj/so/util/test.o -Lobj/so -lre2 obj/libre2.a $(LDFLAGS) $(LDPCRE) I'm not sure about mimics_pcre_test mentioned below, but filtered_re2_test is failing because it tries to increase the FLAGS_filtered_re2_min_atom_len parameter variable from the default 3 to 4, and then checks that atoms of length 3 are discarded. However, it's setting the copy of the variable from the static library and then calling the code from the shared library, which has its own copy of the variable which is still the default. The variable is in fact not exported from the shared library at all, so applications that use it have no hope of being able to change the parameter. For some reason, if the above-mentioned patch is commented out, the test ends up calling the copy of the code from the static library, so the change to the variable is respected. I'm not sure why the patch makes a difference, since as far as I can see the functions the test is using are exported from the shared library either way. I imagine the fix would be to add the FLAGS_ variable to the exported symbols list (actually there are a couple of others as well), and probably remove obj/libre.a from the linker command to avoid this sort of mixup. It's too late for me to test that right now though.
(In reply to comment #6) > I imagine the fix would be to add the FLAGS_ variable to the exported > symbols list (actually there are a couple of others as well), and probably > remove obj/libre.a from the linker command to avoid this sort of mixup. > It's too late for me to test that right now though. So the latter part of that doesn't work easily because there are a lot of other symbols that the tests use that aren't exported by the shared library, and the commentary at https://codereview.appspot.com/674041 suggests that the exports are quite limited deliberately, which makes me a bit more reluctant to add the FLAGS_* variable to the list. > For some reason, if the above-mentioned patch is commented out, the test ends > up calling the copy of the code from the static library, so the change to the > variable is respected. I'm not sure why the patch makes a difference, since as > far as I can see the functions the test is using are exported from the shared > library either way. Turns out that's not quite correct, filtered_re2_test does call some affected functions, but ones that are defined in filtered_re2.o, not prefilter_tree.o where the FLAGS_ variable is defined. However, filtered_re2.o uses prefilter_tree.o, so forcing the static library copy of the former probably causes the latter to be used even for the functions that are exported from the shared library. But that's really just a detail anyway. (In reply to comment #4) > My current suspicion: running make shared-tests vs. make test which upstream > is using. It is indeed starting to look like shared-tests is inherently pretty broken, since it's apparently trying to test internal functionality that's deliberately not exposed by the shared library, so it has to pull in both the shared and static libraries, which is a recipe for weird behaviour. It seems to be just a fluke that it works without the patch that the ebuild applies.
Fixed in re2-0_p20130712.
