Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 442956 - mozlinguas.eclass: Please don't use ${MOZ_P} for downloaded language packs
Summary: mozlinguas.eclass: Please don't use ${MOZ_P} for downloaded language packs
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Low enhancement
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-13 09:31 UTC by Lars Wendler (Polynomial-C) (RETIRED)
Modified: 2012-11-18 10:48 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
mozlinguas.eclass.patch (mozlinguas.eclass.patch,1013 bytes, patch)
2012-11-13 09:31 UTC, Lars Wendler (Polynomial-C) (RETIRED)
Details | Diff
mozlinguas.eclass.patch (mozlinguas.eclass.patch,722 bytes, patch)
2012-11-17 16:45 UTC, Lars Wendler (Polynomial-C) (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2012-11-13 09:31:01 UTC
Created attachment 329450 [details, diff]
mozlinguas.eclass.patch

Please see attached patch.

For testing purposes I'm sometimes adding _pre releases of mozilla packages to my private overlay. A typical example name of such an ebuild is seamonkey-2.14_beta4_pre1.ebuild. With our current mozlinguas eclass the language packages get the following name:

seamonkey-2.14b4-de.xpi

As you can see, the whole _pre1 version tag is cut away (because of ${MOZ_P} in the eclass) which later when I add the final seamonkey-2.14_beta4.ebuild to my overlay leads to wrong checsums because the language packs for the final package have the same name like the ones from my _pre1 ebuild.

The attached patch is using ${P} instead of ${MOZ_P}. I tested the patched eclass in my overlay for about two weeks now and couldn't find any problems. The language packs for my _pre ebuilds now have the following name:

seamonkey-2.14_beta4_pre1-de.xpi

Please give it a test and report your results back here.
Comment 1 Jory A. Pratt gentoo-dev 2012-11-17 16:06:52 UTC
This solution is no good as well, we do not need to have our mirrors loaded with multiple xpi files that are the same with different names for source and -bin packages.
Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2012-11-17 16:45:40 UTC
Created attachment 329728 [details, diff]
mozlinguas.eclass.patch

Fair enough. Then how about this patch?
Comment 3 Jory A. Pratt gentoo-dev 2012-11-17 19:12:58 UTC
(In reply to comment #2)
> Created attachment 329728 [details, diff] [details, diff]
> mozlinguas.eclass.patch
> 
> Fair enough. Then how about this patch?

Why not just override MOZ_PV with MOZ_PV="PVR" in the ebuild your using at the time.
Comment 4 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2012-11-18 10:48:25 UTC
Alright I will modify my ebuilds. Thanks for your input :)