Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 442778 - app-benchmarks/ramspeed-2.6.0: fails to build with hardened/PIE
Summary: app-benchmarks/ramspeed-2.6.0: fails to build with hardened/PIE
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Dane Smith (RETIRED)
URL: https://tinderboxlogs.s3.amazonaws.co...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-11 17:07 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2012-12-01 18:09 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2012-11-11 17:07:01 UTC
Portage 2.2.0_alpha142 (hardened/linux/amd64/no-multilib, gcc-4.5.4-asneeded-asneeded, glibc-2.15-r3, 3.4.7-hardened x86_64)
=================================================================
System uname: Linux-3.4.7-hardened-x86_64-AMD_Opteron-TM-_Processor_6272-with-gentoo-2.1
Timestamp of tree: Fri, 02 Nov 2012 20:00:01 +0000
ld GNU ld (GNU Binutils) 2.22
distcc 3.1 x86_64-pc-linux-gnu [disabled]
ccache version 3.1.7 [disabled]
app-shells/bash:          4.2_p37
dev-java/java-config:     2.1.11-r3
dev-lang/python:          2.6.8, 2.7.3-r2, 3.2.3
dev-util/ccache:          3.1.7
dev-util/cmake:           2.8.9
sys-apps/baselayout:      2.1-r1
sys-apps/openrc:          0.9.8.4
sys-apps/sandbox:         2.5
sys-devel/autoconf:       2.13, 2.68
sys-devel/automake:       1.4_p6-r1, 1.9.6-r3, 1.10.3, 1.11.6
sys-devel/binutils:       2.22-r1
sys-devel/gcc:            4.5.4
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4-r1
sys-devel/make:           3.82-r3
sys-kernel/linux-headers: 3.4-r2 (virtual/os-headers)
sys-libs/glibc:           2.15-r3
Repositories: gentoo
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -ggdb -march=native -ftracer -frecord-gcc-switches"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /opt/openfire/resources/security/ /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/maven-bin-2.2/conf /usr/share/openvpn/easy-rsa /usr/share/themes/oxygen-gtk/gtk-2.0 /var/bind /var/lib/hsqldb /var/qmail/alias /var/qmail/control /var/spool/torque /var/vpopmail/etc /var/yp/Makefile"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/games/angband/edit/ /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.3/ext-active/ /etc/php/apache2-php5.4/ext-active/ /etc/php/cgi-php5.3/ext-active/ /etc/php/cgi-php5.4/ext-active/ /etc/php/cli-php5.3/ext-active/ /etc/php/cli-php5.4/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe -ggdb -march=native -ftracer -frecord-gcc-switches"
DISTDIR="/var/cache/portage/distfiles"
FCFLAGS="-O2 -pipe -ggdb -march=native -frecord-gcc-switches"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fail-clean fixlafiles merge-sync news parallel-fetch protect-owned sandbox sfperms strict test test-fail-continue unknown-features-warn unmerge-orphans userfetch userpriv usersandbox"
FFLAGS="-O2 -pipe -ggdb -march=native -frecord-gcc-switches"
GENTOO_MIRRORS="http://ftp.ucsb.edu/pub/mirrors/linux/gentoo/ http://gentoo.mirrors.hoobly.com/ http://gentoo.llarian.net/"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j24"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/tmp"
PORTDIR="/var/cache/tinderbox/tree"
PORTDIR_OVERLAY=""
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="3dnow 3dnowex acl amd64 berkdb bzip2 cli cracklib crypt cups curl cxx dri ffmpeg gdbm gpm hardened iconv introspection ipv6 justify mmx modules mudflap ncurses nls nptl openmp pam pax_kernel pcre plasma pppd qt3support readline semantic-desktop session sse sse2 sse3 sse4 ssl ssse3 tcpd unicode urandom vhosts zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" PHP_TARGETS="php5-3" PYTHON_TARGETS="python3_2 python2_7" RUBY_TARGETS="ruby18 ruby19" USERLAND="GNU" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, LINGUAS, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
Comment 1 Anthony Basile gentoo-dev 2012-11-12 10:47:37 UTC
The problem is its all written in pic unfriendly assembly.  The easiest approach is to turn of pic/pie using LDFLAGS=-nopie.

Here's a patch to 2.6.0.  Same issue with 3.5.0.  I'll just inline it since its easy enough:

--- ramspeed-2.6.0.ebuild.orig	2012-11-12 05:40:10.000000000 -0500
+++ ramspeed-2.6.0.ebuild	2012-11-12 05:44:22.000000000 -0500
@@ -12,7 +12,7 @@
 LICENSE="Alasir"
 SLOT="0"
 KEYWORDS="amd64 x86"
-IUSE="sse"
+IUSE="sse hardened"
 
 src_prepare(){
 	tc-export CC AS
@@ -27,6 +27,12 @@
 
 	#fix the stack
 	append-ldflags -Wl,-z,noexecstack
+
+	#avoid pic unfriendly assembly
+	if use hardened; then
+		append-ldflags -nopie
+	fi
+
 	obj=( ramspeed.o ${arch_prefix}{fltmark,fltmem,intmark,intmem}.o )
 
 	if use x86; then
Comment 2 Magnus Granberg gentoo-dev 2012-11-12 13:54:38 UTC
(In reply to comment #1)
> The problem is its all written in pic unfriendly assembly.  The easiest
> approach is to turn of pic/pie using LDFLAGS=-nopie.
> 
> Here's a patch to 2.6.0.  Same issue with 3.5.0.  I'll just inline it since
> its easy enough:
> 
> --- ramspeed-2.6.0.ebuild.orig  2012-11-12 05:40:10.000000000 -0500
> +++ ramspeed-2.6.0.ebuild       2012-11-12 05:44:22.000000000 -0500
> @@ -12,7 +12,7 @@
>  LICENSE="Alasir"
>  SLOT="0"
>  KEYWORDS="amd64 x86"
> -IUSE="sse"
> +IUSE="sse hardened"
>  
>  src_prepare(){
>         tc-export CC AS
> @@ -27,6 +27,12 @@
>  
>         #fix the stack
>         append-ldflags -Wl,-z,noexecstack
> +
> +       #avoid pic unfriendly assembly
> +       if use hardened; then
> +               append-ldflags -nopie
> +       fi
> +
>         obj=( ramspeed.o ${arch_prefix}{fltmark,fltmem,intmark,intmem}.o )
>  
>         if use x86; then
Use pic instead of hardened
Comment 3 Anthony Basile gentoo-dev 2012-11-20 18:25:12 UTC
(In reply to comment #2)
> Use pic instead of hardened

ping @c1pher.  Go ahead and commit without revbump?
Comment 4 Anthony Basile gentoo-dev 2012-11-29 00:20:36 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > +
> > +       #avoid pic unfriendly assembly
> > +       if use hardened; then
> > +               append-ldflags -nopie
> > +       fi
> > +
> >         obj=( ramspeed.o ${arch_prefix}{fltmark,fltmem,intmark,intmem}.o )
> >  
> >         if use x86; then
> Use pic instead of hardened

Zorry are you sure about pic vs hardened, because we need this on amd64 where we have USE="-pic".  I see why you're suggestiing pic, but if I do, then I would have to add "app-benchmarks/ramspeed pic" to hardened/linux/amd64/package.use like we do for mesa and others.
Comment 5 Anthony Basile gentoo-dev 2012-12-01 18:09:30 UTC
Okay I fixed the asm for amd64 so that it is PIC friendly.  So on amd64 is compiles just fine with USE="-pic" and on x86 where we have USE="pic" we append -nopie to the CFLAGS.

This is in the tree with ramspeed-3.5.0-r1.