Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 442426 - [patch] ecopy does not check for make.profile in $EPREFIX/etc/portage
Summary: [patch] ecopy does not check for make.profile in $EPREFIX/etc/portage
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2012-11-09 13:13 UTC by Cyprien Nicolas (fulax)
Modified: 2012-12-05 13:36 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch against # $Id: ecopy 59314 2011-02-16 03:45:16Z darkside $ (ecopy-new-make.profile-location.patch,1.12 KB, patch)
2012-11-09 13:13 UTC, Cyprien Nicolas (fulax)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cyprien Nicolas (fulax) 2012-11-09 13:13:17 UTC
Created attachment 329012 [details, diff]
patch against # $Id: ecopy 59314 2011-02-16 03:45:16Z darkside $

I noticed that ecopy sources make.defaults from /etc/make.profile, thus ignoring the new default location in /etc/portage for recent installs:

$ ~/gprefix/usr/portage/scripts/ecopy dev-python/gnome-keyring-python
(snip)
Processing gnome-keyring-python-2.32.0.ebuild
  replacing ${D} -> ${ED} ... not found
  replacing ${ROOT} -> ${EROOT} ... not found
Processing gnome-keyring-python-2.32.0.ebuild ... 
/user/cnicolas/home/gprefix/usr/portage/scripts/ecopy: line 134: /home/cnicolas/gprefix/etc/make.profile/make.defaults: No such file or directory
(snip)

I made a small patch, sourcing first the new make.defaults location, is missing, fallback on the old location. I don't know what behavior is expected if no profile is set. I just put an einfo. Please improve :)

I also didn't put the quotes inside [[ ]], as they are useless IIRC. Please add them if I were wrong.
Comment 1 Fabian Groffen gentoo-dev 2012-11-09 13:18:05 UTC
I think there is no reason to use ecopy any more these days.  We have the full tree now, so you just have to "fix" the ebuilds.
Comment 2 Cyprien Nicolas (fulax) 2012-11-09 13:44:37 UTC
Okay, thanks for the info. I'm new to prefix, and the docs are quite old.

So maybe one should add some ewarn at the beginning of ecopy to tell the user that ecopy is deprecated?
Comment 3 Fabian Groffen gentoo-dev 2012-11-09 13:50:19 UTC
yeah, or just remove it/remove it from the docs
Comment 4 Fabian Groffen gentoo-dev 2012-12-05 13:36:10 UTC
documentation pointers removed.

ecopy removed from scripts