Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 441958 - =dev-libs/xxl-1.0.1-r1 keyword request
Summary: =dev-libs/xxl-1.0.1-r1 keyword request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Keywording and Stabilization (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: KEYWORDREQ
Depends on:
Blocks:
 
Reported: 2012-11-05 23:52 UTC by Vicente Olivert Riera (RETIRED)
Modified: 2012-11-08 10:03 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
improve-the-ebuild.patch (improve-the-ebuild.patch,858 bytes, patch)
2012-11-05 23:52 UTC, Vicente Olivert Riera (RETIRED)
Details | Diff
improve-the-ebuild.patch (improve-the-ebuild.patch,888 bytes, patch)
2012-11-06 00:28 UTC, Vicente Olivert Riera (RETIRED)
Details | Diff
new-revision.patch (new-revision.patch,857 bytes, patch)
2012-11-06 01:03 UTC, Vicente Olivert Riera (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vicente Olivert Riera (RETIRED) gentoo-dev 2012-11-05 23:52:19 UTC
Created attachment 328498 [details, diff]
improve-the-ebuild.patch

Keywords for dev-libs/xxl:
      |                           | u   |  
      | a a             p     s   | n   |  
      | l m   h i m m   p s   p   | u s | r
      | p d a p a 6 i p c 3   a x | s l | e
      | h 6 r p 6 8 p p 6 9 s r 8 | e o | p
      | a 4 m a 4 k s c 4 0 h c 6 | d t | o
------+---------------------------+-----+-------
1.0.1 | o o o o o o o o o o o o + | o 0 | gentoo

Please keyword =dev-libs/xxl-1.0.1 for amd64.

Tested amd64: looks fine here.

I have attached a patch to improve the current ebuild. The changes are:

-bumped to EAPI4
-uses the DOCS variable
-added static-libs IUSE
-remove unnecesari .la files

There are no packages on portage tree depending on dev-libs/xxl, so, I can't compile anything against it, sorry.
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2012-11-06 00:06:06 UTC
Hrm I'd say that the keywording can wait if it's the first one, the improvement patch is good(ish), but since it's an EAPI bump, it should have a revision bump, so it'll delay stabling.

Also since nothing is using it, stabling it doesn't sound like a great idea, especially if it's orphaned.

Does the package use autotools? I'd say so given the prune_libtool_files call — in that case you want to make sure to econf --disable-static when static-libs USE flag is disabled, to avoid building it at all, and not just to avoid installing it.
Comment 2 Vicente Olivert Riera (RETIRED) gentoo-dev 2012-11-06 00:28:53 UTC
Created attachment 328506 [details, diff]
improve-the-ebuild.patch

Thanks to Diego for the advice.
Comment 3 Vicente Olivert Riera (RETIRED) gentoo-dev 2012-11-06 01:03:28 UTC
Created attachment 328508 [details, diff]
new-revision.patch

The last one, I promise.
Comment 4 Sergey Popov gentoo-dev 2012-11-08 10:03:56 UTC
(In reply to comment #1)
>since it's an EAPI bump, it should have a revision bump, so it'll delay stabling.

Diego, this bug is not about stabling, it is about keywording, so i commit new(keyworded) revision and close this as FIXED.

+*xxl-1.0.1-r1 (08 Nov 2012)
+
+  08 Nov 2012; Sergey Popov <pinkbyte@gentoo.org> +xxl-1.0.1-r1.ebuild:
+  Revision bump: bump to EAPI 4, add 'static-libs' and 'threads' USE-flags,
+  keyword on ~amd64 wrt bug #441958, thanks to Vicente Olivert Riera