Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 441748 - net-misc/NetworkManager 0.9.6.4: 0.9_rc3-fix-tests.patch should be removed
Summary: net-misc/NetworkManager 0.9.6.4: 0.9_rc3-fix-tests.patch should be removed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Nirbheek Chauhan (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-04 14:05 UTC by Pavel Šimerda
Modified: 2012-11-05 03:59 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Šimerda 2012-11-04 14:05:02 UTC 
0.9_rc3-fix-tests.patch in NetworkManager 0.9.6.4 should be removed.

1) This patch is not (or should not be) necessary to build the package

2) It breaks the possibility to test part of the software (FEATURE=test)

3) The minor problem of building tests that are not used can be easily
fixed upstream for next releases. I can do it for you.

Cheers,

Pavel
Comment 1 Pavel Šimerda 2012-11-04 14:17:39 UTC 
By the way, calling a patch that removes tests 'fix-tests' is just ridiculous.
Comment 2 Alexandre Rostovtsev (RETIRED) gentoo-dev 2012-11-05 03:59:45 UTC 
You are right, thanks for the report. The patch has been removed.

>  05 Nov 2012; Alexandre Rostovtsev <tetromino@gentoo.org>
>  -files/networkmanager-0.9_rc3-fix-tests.patch,
>  networkmanager-0.9.4.0-r5.ebuild, networkmanager-0.9.4.0-r6.ebuild,
>  networkmanager-0.9.4.0-r7.ebuild, networkmanager-0.9.6.0.ebuild,
>  networkmanager-0.9.6.4.ebuild:
>  Do not hard-disable tests since they pass (bug #441748, thanks to Pavel
>  Šimerda).