439608 – cmake.eclass: improve dev-util/ninja support

Bug 439608 - cmake.eclass: improve dev-util/ninja support

Summary: cmake.eclass: improve dev-util/ninja support

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Eclasses (show other bugs)
Hardware:	All Linux

Importance:	Normal normal
Assignee:	Gentoo KDE team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2012-10-25 13:11 UTC by Tomáš Chvátal (RETIRED)
Modified:	2013-02-11 15:41 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
cmake-utils.eclass.patch (cmake-utils.eclass.patch,3.74 KB, patch) 2012-10-25 13:11 UTC, Tomáš Chvátal (RETIRED)	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tomáš Chvátal (RETIRED) gentoo-dev

2012-10-25 13:11:54 UTC

Created attachment 327392 [details, diff]
cmake-utils.eclass.patch

When I was fixing one bug in the eclass I found out you guys included not exactly nice code for ninja build system.

I did naive approach trying to fix it, see the attachment and include it.

I am not exactly sure if we can be this generic in install phase or rather do same thing like I did in make one.

Comment 1 Michael Palimaka (kensington) gentoo-dev

2013-01-02 15:54:22 UTC

Happy to have this migrated to portage?

Comment 2 Tomáš Chvátal (RETIRED) gentoo-dev

2013-01-02 17:07:15 UTC

Sure, if it is tested :-)

Comment 3 Tomáš Chvátal (RETIRED) gentoo-dev

2013-02-01 22:39:57 UTC

I would say it is in overlay for long enough, to main tree with it :-)

Comment 4 Michael Palimaka (kensington) gentoo-dev

2013-02-07 15:42:18 UTC

Thanks, fixed in CVS.

+  07 Feb 2013; Michael Palimaka <kensington@gentoo.org> cmake-utils.eclass:
+  Export src_prepare. Improve support for dev-util/ninja wrt bug #439608. Add
+  support for CMAKE_DISABLE_FIND_PACKAGE wrt bug #453746.