Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 439548 - Please stabilize =sys-process/htop-1.0.1-r1
Summary: Please stabilize =sys-process/htop-1.0.1-r1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Keywording and Stabilization (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Christian Ruppert (idl0r)
URL:
Whiteboard:
Keywords: STABLEREQ
Depends on:
Blocks:
 
Reported: 2012-10-24 20:27 UTC by Christian Ruppert (idl0r)
Modified: 2012-12-16 15:18 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Ruppert (idl0r) gentoo-dev 2012-10-24 20:27:20 UTC
Guys, please stabilize =sys-process/htop-1.0.1-r1.

Actually -r1 just got some minor enhancements so I guess most arches don't need to do too much testing.
<snip>
 pkg_setup() {
-	if use elibc_FreeBSD && ! [[ -f ${ROOT}/proc/stat && -f ${ROOT}/proc/meminfo ]]; then
+	if use kernel_FreeBSD && ! [[ -f ${ROOT}/compat/linux/proc/stat && -f ${ROOT}/compat/linux/proc/meminfo ]]; then
 		eerror
-		eerror "htop needs /proc mounted to compile and work, to mount it type"
-		eerror "mount -t linprocfs none /proc"
-		eerror "or uncomment the example in /etc/fstab"
+		eerror "htop requires linprocfs mounted at /compat/linux/proc to build and function."
+		eerror "To mount it, type:"
+		[ -d /compat/linux/proc ] || eerror "mkdir -p /compat/linux/proc"
+		eerror "mount -t linprocfs none /compat/linux/proc"
+		eerror "Alternatively, place this information into /etc/fstab"
 		eerror
-		die "htop needs /proc mounted"
+		die "htop needs /compat/linux/proc mounted"
 	fi
 
 	if ! has_version sys-process/lsof; then
@@ -45,10 +47,15 @@ src_prepare() {
 src_configure() {
 	[[ $CBUILD != $CHOST ]] && export ac_cv_file__proc_{meminfo,stat}=yes #328971
 
+	myconf=''
+
+	use kernel_FreeBSD && myconf="${myconf} --with-proc=/compat/linux/proc"
+
 	econf \
 		$(use_enable openvz) \
 		$(use_enable kernel_linux cgroup) \
 		$(use_enable vserver) \
 		$(use_enable unicode) \
-		--enable-taskstats
+		--enable-taskstats \
+		${myconf}
 }
</snip>
Comment 1 Jean-Pierre de la Croix (jdelacroix) 2012-10-24 21:06:33 UTC
amd64 tested ok
Comment 2 Elijah "Armageddon" El Lazkani (amd64 AT) 2012-10-24 21:10:23 UTC
amd64: pass

NB: repoman complains
   sys-process/htop/htop-1.0.1-r1.ebuild: no function called from autotools.eclass; please drop
Comment 3 Anthony Basile gentoo-dev 2012-10-24 23:33:02 UTC
stable arm ppc ppc64
Comment 4 mike 2012-10-25 17:14:59 UTC
x86 ok (repoman mostly ok: see Comment 2, compiles ok, usage test ok)
Comment 5 Markos Chandras (RETIRED) gentoo-dev 2012-10-28 16:58:59 UTC
amd64 done. Thanks Elijah and Jean-Pierre de la Croix
Comment 6 Jeroen Roovers (RETIRED) gentoo-dev 2012-10-30 15:51:07 UTC
Stable for HPPA.
Comment 7 Petr Wolf (Woofie) 2012-10-30 17:27:54 UTC
x86 ok ( build ok, test ok, run ok ) repomen was mention
Comment 8 Agostino Sarubbo gentoo-dev 2012-11-21 10:17:20 UTC
x86 stable
Comment 9 Raúl Porcel (RETIRED) gentoo-dev 2012-12-16 15:18:39 UTC
alpha/ia64/sh/sparc stable