Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 439536 - x11-terms/rxvt-unicode-9.15-r1: line spacing differ from xterm
Summary: x11-terms/rxvt-unicode-9.15-r1: line spacing differ from xterm
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jeroen Roovers (RETIRED)
URL: http://lists.schmorp.de/mailman/listi...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2012-10-24 17:59 UTC by Alex Efros
Modified: 2012-10-25 19:26 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
line-spacing-fix (line-spacing-fix.patch,801 bytes, patch)
2012-10-24 17:59 UTC, Alex Efros
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Efros 2012-10-24 17:59:52 UTC
Created attachment 327314 [details, diff]
line-spacing-fix

With same font line spacing used by urxvt is larger than one used by xterm. Using resource lineSpace it's possible to even more increase line spacing, but not possible to decreased it (using 0 or negative values).

I've found patch for this issue in Arch AUR - it works ok. Please consider adding it to portage (probably activated by custom USE flag like most other patches in current ebuild).
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2012-10-25 15:14:07 UTC
Please send patches upstream.
Comment 2 Alex Efros 2012-10-25 19:26:13 UTC
(In reply to comment #1)
> Please send patches upstream.

Usually I do. But not this time:

At first, I've no idea is this patch does something right or wrong. It makes urxvt work in same way as xterm, but that doesn't mean xterm's way is right and urxvt's is wrong. I'm in no way X expert and can't decide this on my own. But even if it does something "wrong", I think it's good to keep it as optional USE-flag controlled feature.

At second, I had conflict some time ago with Marc Lehmann (urxvt author) and he blacklisted my email, so I'm not really right person to send patches to him.

And last, I think it's better when patch author send it upstream (i.e. someone from Arch AUR in this case), because he at least have an idea what and why this patch does and can discuss this with upstream in case they'll have questions about it.