439426 – [gnome overlay] mutter 3.6.1

Bug 439426 - [gnome overlay] mutter 3.6.1

Summary: [gnome overlay] mutter 3.6.1

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] GNOME (show other bugs)
Hardware:	All Linux

Importance:	Normal normal
Assignee:	Gentoo Linux Gnome Desktop Team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2012-10-23 17:24 UTC by Sobhan Mohammadpour (RETIRED)
Modified:	2012-10-24 09:10 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
patch for it (0001-mutter-3.6.0-mutter-3.6.1.patch,10.22 KB, text/plain) 2012-10-23 17:24 UTC, Sobhan Mohammadpour (RETIRED)	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Sobhan Mohammadpour (RETIRED) gentoo-dev

2012-10-23 17:24:51 UTC

Created attachment 327246 [details]
patch for it

i updated the ebuild for mutter

Comment 1 Alexandre Rostovtsev (RETIRED) gentoo-dev

2012-10-24 09:10:04 UTC

Thanks for the patch!

Review:

">=x11-libs/pango-1.2[X,introspection?]" was already in COMMON_DEPEND. So adding ">=x11-libs/pango-1.2.0" to DEPEND was not needed.

DEPEND means build-time dependencies. Mutter needs pango both at build time (DEPEND) and at runtime (RDEPEND), which is why we include it in the COMMOND_DEPEND list, which is then included in RDEPEND and DEPEND.

Stylistic note - please use something like "x11-wm/mutter: 3.6.0 → 3.6.1", not "mutter 3.6.0 -> mutter 3.6.1" for the commit title.

Please run "git config diff.renames copies" in your repository so that file renames in the patch text are displayed in a more compact and easier to read manner.


Committed: http://git.overlays.gentoo.org/gitweb/?p=proj/gnome.git;a=commitdiff;h=8b157757054a330635d25d8e210a3fb2dac7497d

Superfluous pango DEPEND removed and build-time variables moved to src_prepare(): http://git.overlays.gentoo.org/gitweb/?p=proj/gnome.git;a=commitdiff;h=5401bd94d14801398f8c7205eb6c7258ae5c5a24