Bug 439268 – cmake-utils.eclass modifies CMakeLists.txt file more than once for out of tree builds

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Reinis Danne 2012-10-22 15:02:42 UTC]

It has a check to prevent multiple modification of CMakeLists.txt when the configure is run multiple times (multilib or different python implementations), but it checks in the wrong place and ends up modifying the file anyway.

Reproducible: Always

Steps to Reproduce:
1. layman -a science
2. emerge -1 =openbabel-python-2.3.2
Actual Results:  
Multiple instances of Gentoo modifications in CMakeLists.txt. Check for "<<< Gentoo configuration >>>".

Expected Results:  
File should be modified only once and it would end up only with one "<<< Gentoo configuration >>>" instance in it.

[Comment 1 Reinis Danne 2012-10-22 15:04:55 UTC]

Created attachment 327150 [details, diff]
cmake-utils.eclass patch

Make sure to check the CMakeLists.txt file in source directory, since current directory will be build directory and it might not be the same.

[Comment 2 Michael Palimaka (kensington) 2012-10-23 12:18:00 UTC]

Thanks, nice spot. This is now in the KDE overlay for testing.

http://git.overlays.gentoo.org/gitweb/?p=proj/kde.git;a=commitdiff;h=b5cd2d840cf430003a584f5550ef76d9b1191193

[Comment 3 Tomáš Chvátal (RETIRED) 2012-10-25 12:48:15 UTC]

Added to main tree.