one-liner, but in many ebuilds: the pulseaudio patchset gets applied no matter if use pulseaudio is set or not. Do I misunderstand the purpose of useflags? Reproducible: Always Steps to Reproduce: emerge wine with USE="-pulseaudio" Actual Results: pulseaudio patches get applied either way Expected Results: would have expected the pulseaudio patchset to be left out depending on use
Created attachment 327088 [details, diff] patch to retroactively only patch when the useflag was set
Comment on attachment 327088 [details, diff] patch to retroactively only patch when the useflag was set All patches should ideally apply generally (not conditionally) and add changes to the source that work out configuring specifically for the feature or enhancement that is being added.
(In reply to comment #2) more specifically, applying the patch does not itself enable pulseaudio support. only the configure flag (which is controlled by the USE flag) later on enables support.