Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 438276 - app-admin/webapp-config-1.50.19 - ignores vhost_config_dir value
Summary: app-admin/webapp-config-1.50.19 - ignores vhost_config_dir value
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal
Assignee: Anthony Basile
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2012-10-13 21:45 UTC by Christian Affolter
Modified: 2013-03-09 13:45 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Affolter 2012-10-13 21:45:50 UTC 
The "vhost_config_dir" configuration value of /etc/vhosts/webapp-config gets ignored in the current stable (1.50.16-r4) and also the latest app-admin/webapp-config-1.50.19

This can be tracked down to ebuild.py where "self.get_config('vhost_config_dir')" is probably missing:

diff -u /usr/lib64/python2.7/site-packages/WebappConfig/ebuild.py{.orig,}
--- /usr/lib64/python2.7/site-packages/WebappConfig/ebuild.py.orig	2012-06-28 02:43:44.000000000 +0200
+++ /usr/lib64/python2.7/site-packages/WebappConfig/ebuild.py	2012-10-13 23:33:35.794339146 +0200
@@ -277,7 +277,7 @@
 
         v_root = self.get_config('vhost_root')
         v_cgi  = self.get_config('g_cgibindir')
-        v_conf = v_root + '/'
+        v_conf = self.get_config('vhost_config_dir')
         v_err  = v_root + '/' + self.get_config('my_errorsbase')
         v_icon = v_root + '/' + self.get_config('my_iconsbase')

Reproducible: Always
Comment 1 Devan Franchini (RETIRED) gentoo-dev 2013-02-17 00:47:25 UTC 
(In reply to comment #0)
> The "vhost_config_dir" configuration value of /etc/vhosts/webapp-config gets
> ignored in the current stable (1.50.16-r4) and also the latest
> app-admin/webapp-config-1.50.19
> 
> This can be tracked down to ebuild.py where
> "self.get_config('vhost_config_dir')" is probably missing:
> 
> diff -u /usr/lib64/python2.7/site-packages/WebappConfig/ebuild.py{.orig,}
> --- /usr/lib64/python2.7/site-packages/WebappConfig/ebuild.py.orig
> 2012-06-28 02:43:44.000000000 +0200
> +++ /usr/lib64/python2.7/site-packages/WebappConfig/ebuild.py	2012-10-13
> 23:33:35.794339146 +0200
> @@ -277,7 +277,7 @@
>  
>          v_root = self.get_config('vhost_root')
>          v_cgi  = self.get_config('g_cgibindir')
> -        v_conf = v_root + '/'
> +        v_conf = self.get_config('vhost_config_dir')
>          v_err  = v_root + '/' + self.get_config('my_errorsbase')
>          v_icon = v_root + '/' + self.get_config('my_iconsbase')
> 
> Reproducible: Always

What webapp were you installing where you found this bug? I need something to test against :)
Comment 2 Devan Franchini (RETIRED) gentoo-dev 2013-03-09 03:14:07 UTC 
basile, the fix makes sense. Feel free to commit whenever you please.