Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 438208 - dev-python/pyftpdlib-0.7.0: failing test doesn't terminate build
Summary: dev-python/pyftpdlib-0.7.0: failing test doesn't terminate build
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Paweł Hajdan, Jr. (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 438190
  Show dependency tree
 
Reported: 2012-10-13 07:53 UTC by Myckel Habets
Modified: 2012-11-17 12:10 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log (pyftpdlib_build.log,25.76 KB, text/plain)
2012-10-13 07:54 UTC, Myckel Habets
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Myckel Habets 2012-10-13 07:53:58 UTC
=dev-python/pyftpdlib-0.7.0 had one failing test on my system with USE="ssl" (see attachment), but it didn't fail the build. Test should be fixed and also the ebuild should fail when tests fail.

Reproducible: Always

Steps to Reproduce:
1. Emerge =dev-python/pyftpdlib-0.7.0 with USE="ssl"
Actual Results:  
Build successful while test fails.

Expected Results:  
Build successful when all tests are successful. Build fails when tests fail.

emerge --info
Portage 2.1.11.9 (default/linux/x86/10.0, gcc-4.5.4, glibc-2.15-r2, 3.3.8-gentoo i686)
=================================================================
System uname: Linux-3.3.8-gentoo-i686-Intel-R-_Celeron-R-_CPU_2.40GHz-with-gentoo-2.1
Timestamp of tree: Fri, 12 Oct 2012 17:30:01 +0000
distcc 3.1 i686-pc-linux-gnu [enabled]
app-shells/bash:          4.2_p37
dev-java/java-config:     2.1.11-r3
dev-lang/python:          2.7.3-r2, 3.2.3
dev-util/cmake:           2.8.7-r5
dev-util/pkgconfig:       0.27.1
sys-apps/baselayout:      2.1-r1
sys-apps/openrc:          0.9.8.4
sys-apps/sandbox:         2.5
sys-devel/autoconf:       2.13, 2.68
sys-devel/automake:       1.11.6
sys-devel/binutils:       2.22-r1
sys-devel/gcc:            4.5.4
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4-r1
sys-devel/make:           3.82-r3
sys-kernel/linux-headers: 3.4 (virtual/os-headers)
sys-libs/glibc:           2.15-r2
Repositories: gentoo x-portage
ACCEPT_KEYWORDS="x86"
ACCEPT_LICENSE="* -@EULA -dlj-1.1"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-march=pentium4 -pipe -ggdb -O2"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.3/ext-active/ /etc/php/cgi-php5.3/ext-active/ /etc/php/cli-php5.3/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=pentium4 -pipe -ggdb -O2"
DISTDIR="/usr/portage/distfiles"
FCFLAGS="-O2 -march=i686 -pipe"
FEATURES="assume-digests binpkg-logs collision-protect config-protect-if-modified distcc distlocks ebuild-locks fixlafiles news nostrip parallel-fetch parse-eapi-ebuild-head protect-owned sandbox sfperms strict test unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv"
FFLAGS="-O2 -march=i686 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="nl"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X accessibility acl alsa apng avahi bash-completion berkdb bluetooth bzip2 cairo cli compat consolekit corefonts cracklib crypt cups curl cxx dbus deprecated devil dri examples expat extensions extras fam fbcon fontconfig fortran fts3 gdbm gdu gif glib gmp gnutls gpm gtk gtk3 gudev hwdb iconv ipv6 java jpeg lapack latex libnotify libssh2 md5sum midi mikmod minizip mmx mod modules mp3 mudflap ncurses nls nptl nsplugin objc ogg opengl openmp pam pcre php pic png policykit postscript pppd python qt3support readline sdl session smpeg sockets sqlite sse sse2 ssl startup-notification svg tcpd threads thunar tiff timidity tk tordns truetype udev unicode v4l2 vorbis webdav x86 xcb xml xvfb zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1 emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="nl" PHP_TARGETS="php5-3" PYTHON_TARGETS="python3_2 python2_7" RUBY_TARGETS="ruby18 ruby19 jruby ree18" USERLAND="GNU" VIDEO_CARDS="vesa intel" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
Comment 1 Myckel Habets 2012-10-13 07:54:42 UTC
Created attachment 326442 [details]
Build log
Comment 2 Myckel Habets 2012-10-13 08:00:49 UTC
Seems to be a regression over current stable.
Comment 3 Thomas Kahle (RETIRED) gentoo-dev 2012-10-16 22:23:35 UTC
Here's 

src_test() {
    testing() {
        PYTHONPATH="build-${PYTHON_ABI}/lib" "$(PYTHON)" test/test_ftpd.py \
            || return 1
        PYTHONPATH="build-${PYTHON_ABI}/lib" "$(PYTHON)" test/test_contrib.py \
            || return 1
    }
    python_execute_function testing
}

This does not die properly if the test fails.  The 'return 1' is irrelevant as python_execute_function seems to not pass on the return value.  I suggest to replace the two 'return 1' by 'die'.

Regarding the test failure:  It doesn't happen for me on amd64, but on a x86 virtual machine it does.
Comment 4 Ian Delaney (RETIRED) gentoo-dev 2012-11-13 12:57:49 UTC
worth trying the above. I can't really test since the test suite doesn't fail, short of manually setting a test to an ensured fail state.

"but on a x86 virtual machine it does" could do with some explaining
Comment 5 Ian Delaney (RETIRED) gentoo-dev 2012-11-17 12:10:07 UTC
blow it. test phases updated, fixed in the tree