Bug 437824 – app-emulation/qemu-1.2.0 add patches from Fedora

• Status: RESOLVED INVALID
• Product: Gentoo Linux

[Description Tiziano Müller (RETIRED) 2012-10-10 12:04:49 UTC]

looking at http://pkgs.fedoraproject.org/cgit/qemu.git/tree/qemu.spec shows that Fedora is applying a looot of patches to the current 1.2.0. 
Some of them make sense for us as well:

* Patch0900: 0001-Revert-qemu-char-Re-connect-for-tcp_chr_write-unconn.patch for https://bugzilla.redhat.com/show_bug.cgi?id=853369
* Patch1: 0001-mips-Fix-link-error-with-piix4_pm_init.patch

... and of course all the already upstreamed spice and usbredir patches.

[Comment 1 Francesco Riosa 2012-10-10 12:29:46 UTC]

dupe of bug #437806
+1 for adding the patches

[Comment 2 Tiziano Müller (RETIRED) 2012-10-10 13:03:52 UTC]

(In reply to comment #0)
> looking at http://pkgs.fedoraproject.org/cgit/qemu.git/tree/qemu.spec shows
> that Fedora is applying a looot of patches to the current 1.2.0. 
> Some of them make sense for us as well:
> 
> * Patch0900: 0001-Revert-qemu-char-Re-connect-for-tcp_chr_write-unconn.patch
> for https://bugzilla.redhat.com/show_bug.cgi?id=853369

should rather be: https://bugzilla.redhat.com/show_bug.cgi?id=853408

[Comment 3 Doug Goldstein (RETIRED) 2012-10-10 13:51:43 UTC]

Please don't open these tickets. I already include the same patches. app-emulation/qemu was added by vapier unkeyworded. It hasn't been updated/refactored yet.

[Comment 4 Doug Goldstein (RETIRED) 2012-10-10 13:55:58 UTC]

The patchset was affected by the move. It will be be fixed more so today. Welcome to ~arch.

[Comment 5 Tiziano Müller (RETIRED) 2012-10-10 14:34:13 UTC]

(In reply to comment #3)
> Please don't open these tickets. I already include the same patches.
> app-emulation/qemu was added by vapier unkeyworded. It hasn't been
> updated/refactored yet.

sorry, thought you did a cleanup when moving the stuff and omitted the patches deliberately. Didn't notice that vapier did a bump of the original qemu ebuilds instead.

[Comment 6 Martin Jansa 2012-10-21 08:55:11 UTC]

(In reply to comment #4)
> The patchset was affected by the move. It will be be fixed more so today.
> Welcome to ~arch.

Looks like something wasn't updated in that refactoring
http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/app-emulation/qemu/qemu-1.2.0.ebuild?r1=1.1&r2=1.2

 * ERROR: app-emulation/qemu-1.2.0 failed (prepare phase):
 *   The source directory '/tmp/tmpfs/portage/app-emulation/qemu-1.2.0/work/qemu-1.2.0' doesn't exist

jama ~ # ls /tmp/tmpfs/portage/app-emulation/qemu-1.2.0/work/
qemu-kvm-1.2.0

adding
S="${WORKDIR}/${MY_P}"
should fix that, but there is also missing patch
/usr/portage/app-emulation/qemu/files/qemu-1.2.0-fix-mipsen.patch

After removing this patch it builds but fails to install:
!!! dobin: /usr/bin/qemu-kvm does not exist

[Comment 7 Doug Goldstein (RETIRED) 2012-10-21 14:51:27 UTC]

(In reply to comment #6)
> (In reply to comment #4)
> > The patchset was affected by the move. It will be be fixed more so today.
> > Welcome to ~arch.
> 
> Looks like something wasn't updated in that refactoring
> http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/app-emulation/qemu/
> qemu-1.2.0.ebuild?r1=1.1&r2=1.2
> 

The ebuild isn't keyworded hence, don't use it or if you do there's no support on any ARCH.

[Comment 8 Doug Goldstein (RETIRED) 2012-10-21 14:52:09 UTC]

In fact, this ticket isn't even the correct place to bring up 1.2.0 issues.

[Comment 9 Jeroen Roovers (RETIRED) 2012-10-24 15:43:02 UTC]

*** Bug 439466 has been marked as a duplicate of this bug. ***