Bug 437540 – media-sound/nted-1.10.18 exports invalid LilyPond markup

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Christopher Harvey 2012-10-07 20:01:18 UTC]

If you create a dotted chord with tremolo then export to lilypond, lilypond will refuse to compile it because of bad syntax.
If you put clefs in the middle of a score lilypond exports also fail.

Reproducible: Always

Steps to Reproduce:
1. create the dotted tremolo chord or clef
2. export to lilypond
3. run "lilypond my-export.ly"



will post patches shortly...

[Comment 1 Christopher Harvey 2012-10-07 20:04:06 UTC]

Created attachment 325942 [details]
failing example

Here is an example of a file that will fail when exported to lilypond markup.

[Comment 2 Christopher Harvey 2012-10-07 20:05:31 UTC]

Created attachment 325944 [details, diff]
patch to fix bad clef exporting

[Comment 3 Christopher Harvey 2012-10-07 20:06:08 UTC]

Created attachment 325946 [details, diff]
patch to fix bad tremolo exporting

[Comment 4 Christopher Harvey 2012-10-07 20:08:24 UTC]

disclaimer: these patches haven't been validated by upstream, and I've only had a chance to do minimal testing up till now. At least the code only touches parts that are run for lilypond exports, so the rest of the program will run the same way.

[Comment 5 Christopher Harvey 2012-10-08 03:12:44 UTC]

Created attachment 325966 [details, diff]
patch to fix bad clef exporting v2

found a bug while testing more complex scores. v2 of this patch exports all sample scores perfectly.

[Comment 6 Markos Chandras (RETIRED) 2012-11-08 09:34:53 UTC]

(In reply to comment #5)
> Created attachment 325966 [details, diff] [details, diff]
> patch to fix bad clef exporting v2
> 
> found a bug while testing more complex scores. v2 of this patch exports all
> sample scores perfectly.

Did you try to contact upstream about your patches?

[Comment 7 Christopher Harvey 2012-11-08 15:20:32 UTC]

(In reply to comment #6)
> Did you try to contact upstream about your patches?

yes, never got an answer.
http://mailman.tu-chemnitz.de/pipermail/nted-user/2012-October/000612.html

[Comment 8 Markos Chandras (RETIRED) 2012-11-08 15:27:07 UTC]

(In reply to comment #7)
> (In reply to comment #6)
> > Did you try to contact upstream about your patches?
> 
> yes, never got an answer.
> http://mailman.tu-chemnitz.de/pipermail/nted-user/2012-October/000612.html

I am pretty sure upstream is 'dead' as they haven't released anything in years. In any case, I can't comment on the patch as I've no idea how this package works internally, so if it works for you, I will go ahead and apply it

[Comment 9 Christopher Harvey 2012-11-08 15:31:58 UTC]

(In reply to comment #8)
> I am pretty sure upstream is 'dead' as they haven't released anything in
> years. In any case, I can't comment on the patch as I've no idea how this
> package works internally, so if it works for you, I will go ahead and apply
> it

I use this package a lot. The patches have been holding up so far. If there is a place you can add me as a contact so I can at least get notification of future bug reports please do so. (I like to maintain things I submit ;)

[Comment 10 Markos Chandras (RETIRED) 2012-11-08 15:35:46 UTC]

Yeah I can add you as maintainer on metadata.xml so all bugs are assigned to you. You can contact me if you have proposed fixes for the bugs. Thanks a lot :)

[Comment 11 Matthias Vill 2012-11-09 14:17:30 UTC]

Ok, then please remove me as maintainer.

[Comment 12 Markos Chandras (RETIRED) 2012-11-09 20:05:27 UTC]

+*nted-1.10.18-r1 (09 Nov 2012)
+
+  09 Nov 2012; Markos Chandras <[e-mail]>
+  +files/nted-1.10.18-lilypond.patch, +nted-1.10.18-r1.ebuild, metadata.xml:
+  Add patch for fixing invalid lilypond export markup. Thanks to Christopher
+  Harvey <[e-mail]>. Bug #437540. Adding him as proxy maintainer
+