Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 437526 - [gnome overlay] ebuild for zenity 3.6
Summary: [gnome overlay] ebuild for zenity 3.6
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-07 15:06 UTC by Sobhan Mohammadpour (RETIRED)
Modified: 2012-10-23 09:26 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild for zenity 3.6 (0001-gnome-extra-zenity-3.4.0-3.6.0.patch,4.45 KB, text/plain)
2012-10-07 15:06 UTC, Sobhan Mohammadpour (RETIRED)
Details
patch for it (0001-gnome-extra-zenity-3.4.0-3.6.0.patch,4.45 KB, patch)
2012-10-07 15:08 UTC, Sobhan Mohammadpour (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sobhan Mohammadpour (RETIRED) gentoo-dev 2012-10-07 15:06:55 UTC
Created attachment 325922 [details]
ebuild for zenity 3.6

i  update the ebuild for zenity
Comment 1 Sobhan Mohammadpour (RETIRED) gentoo-dev 2012-10-07 15:08:38 UTC
Created attachment 325924 [details, diff]
patch for it
Comment 2 Alexandre Rostovtsev (RETIRED) gentoo-dev 2012-10-23 09:26:31 UTC
Thanks for the patch!

Review:

In the patch, manifest refers to files (zenity-2.32.1-libnotify-0.7.patch, zenity-3.4.0-list-check.patch, etc.) that are not in the overlay and that are not added by the patch.

The ebuild inherits eutils, but the does not use any functions from eutils.eclass (zenity-3.4.0 needed eutils.eclass for epatch).

docbook-xml-dtd and gnome-doc-utils are no longer needed.

The ebuild's configure script now checks for itstool, but it turns out to not be needed during the build process for non-live (i.e. not -9999 version) zenity. So the choices are either adding itstool to DEPEND, or passing ITSTOOL=$(type -P true) to configure. It also turns out that the package's test suite now needs yelp-tools (it checks user help files for xml errors). Since yelp-tools is not needed when not running the test suite, we can add a test USE flag, and make the yelp-tools dependency conditional on it.

You forgot to set DOCS; despite EAPI4, it's still needed for gnome2_src_install.

Finally, there is a stylistic issue that you probably haven't heard about: the gnome team has only last week decided to start setting variables that are only relevant at build time (e.g. DOCS and G2CONF) in src_prepare() instead of pkg_setup(). [The distinction is that pkg_setup() also gets run when installing a compiled binary package, so setting G2CONF there makes little sense, and it annoys people who extensively use binpkgs.]

Committed: http://git.overlays.gentoo.org/gitweb/?p=proj/gnome.git;a=commit;h=5fb9ffa33458a33303f93627693f98efc63a97e9

Issues discussed above fixed: http://git.overlays.gentoo.org/gitweb/?p=proj/gnome.git;a=commit;h=4e91a401b7d5d22427b046da7fcb050a81b1b363