Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 436930 - media-libs/libextractor-0.6.3: bundles minizip code from zlib
Summary: media-libs/libextractor-0.6.3: bundles minizip code from zlib
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Samuli Suominen (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-02 05:12 UTC by SpanKY
Modified: 2014-07-14 14:59 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description SpanKY gentoo-dev 2012-10-02 05:12:02 UTC
it was more obvious in libextractor-0.5.23, but libextractor has copied minizip from zlib into src/common/unzip.c.  it should use -lminizip instead.

might need a little work to remove the libextractor-specific symbols from the unzip.c code though.
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2012-10-02 12:04:33 UTC
this is likely still true for 1.0.0
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2014-07-14 14:59:13 UTC
(In reply to SpanKY from comment #0)
> might need a little work to remove the libextractor-specific symbols from
> the unzip.c code though.

the unzip.c from >=libextractor-1.3 looks very different from code of unzip.c from >=zlib-1.2.8
even if they used the old unzip.c from old zlib as initial example for writing libextractor's unzip.c, they have now evolved into different direction
this doesn't look something we should be doing, but you could suggest it to upstream if they want to rewrite the file