Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 436836 - net-misc/remmina USE=avahi - src_configure() finds net-dns/avahi but does not use it in src_compile()
Summary: net-misc/remmina USE=avahi - src_configure() finds net-dns/avahi but does not...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mike Gilbert
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2012-10-01 21:47 UTC by Malte Starostik
Modified: 2012-10-07 00:34 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
remmina-1.0.0_p20120309-fix-avahi.patch (remmina-1.0.0_p20120309-fix-avahi.patch,888 bytes, patch)
2012-10-01 21:48 UTC, Malte Starostik
Details | Diff
Build log with original package (net-misc:remmina-1.0.0_p20120309:20121001-144643.log,121.71 KB, text/plain)
2012-10-01 21:50 UTC, Malte Starostik
Details
Build log with patch applied (net-misc:remmina-1.0.0_p20120309:20121001-213155.log,123.64 KB, text/plain)
2012-10-01 21:52 UTC, Malte Starostik
Details
Complete fix as applied upstream (remmina-1.0.0_p20120309-fix-avahi.patch,1.20 KB, patch)
2012-10-03 14:47 UTC, Malte Starostik
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Malte Starostik 2012-10-01 21:47:21 UTC
net-misc/remmina finds avahi in the configure phase, but the appropriate defines don't make it to the compiler options.

I'll attach a patch that fixes this, but it was only created by trial and error and I have no idea why it works.  Just as well as I have no idea whether this is a general problem (upstream probably would have noticed), a Gentoo specific problem (someone maybe should have noticed?), or my setup (but what exactly?).

Reproducible: Always

Steps to Reproduce:
1. USE=avahi emerge net-misc/remmina
2. try to use remmmina's avahi based discovery features

Actual Results:  
Avahi support isn't compiled in

Expected Results:  
There should be a menu icon in the tray icon's menu to enable service discovery and a browse button in the connection dialog.

Portage 2.2.0_alpha134 (default/linux/amd64/10.0/desktop/kde, gcc-4.5.4, glibc-2.15-r2, 3.4.9-gentoo-stellaware x86_64)
=================================================================
System uname: Linux-3.4.9-gentoo-stellaware-x86_64-Intel-R-_Core-TM-2_Duo_CPU_E6750_@_2.66GHz-with-gentoo-2.1
Timestamp of tree: Mon, 01 Oct 2012 13:45:01 +0000
distcc 3.1 x86_64-pc-linux-gnu [disabled]
app-shells/bash:          4.2_p37
dev-java/java-config:     2.1.11-r3
dev-lang/python:          2.7.3-r2, 3.2.3
dev-util/cmake:           2.8.9
dev-util/pkgconfig:       0.27.1
sys-apps/baselayout:      2.1-r1
sys-apps/openrc:          0.10.5::usrmerge
sys-apps/sandbox:         2.5
sys-devel/autoconf:       2.13, 2.68
sys-devel/automake:       1.10.3, 1.11.6
sys-devel/binutils:       2.22-r1
sys-devel/gcc:            4.5.4
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4-r1
sys-devel/make:           3.82-r3
sys-kernel/linux-headers: 3.4-r2 (virtual/os-headers)
sys-libs/glibc:           2.15-r2
Repositories: gentoo crossdev bircoph sunrise systemd-migration stellaware
ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA AdobeFlash-10.3 googleearth Oracle-BCLA-JavaSE PUEL"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=core2 -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/openvpn/easy-rsa /usr/share/plymouth/bizcom.png /usr/share/themes/oxygen-gtk/gtk-2.0 /usr/share/themes/oxygen-gtk/gtk-3.0"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.3/ext-active/ /etc/php/apache2-php5.4/ext-active/ /etc/php/cgi-php5.3/ext-active/ /etc/php/cgi-php5.4/ext-active/ /etc/php/cli-php5.3/ext-active/ /etc/php/cli-php5.4/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=core2 -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--jobs --load-average=3.0"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs candy clean-logs config-protect-if-modified distlocks ebuild-locks fixlafiles news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://de-mirror.org/distro/gentoo/"
LANG="de_DE.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="de en"
MAKEOPTS="-j3 -l3"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/mnt/portage/repo/gentoo"
PORTDIR_OVERLAY="/usr/local/portage/crossdev /mnt/portage/repo/bircoph /mnt/portage/repo/sunrise /mnt/portage/repo/stellaware-systemd /mnt/portage/repo/stellaware"
SYNC="rsync://rsync.de.gentoo.org/gentoo-portage"
USE="X a52 aac aalib acl acpi alsa amd64 amr avahi berkdb bluetooth branding bzip2 cairo calendar caps cdda cdr cli cracklib crypt cups curl cxx dbus declarative device-mapper dga djvu dri dts dv dvb dvd dvdr emboss encode exif ffmpeg firefox flac fontconfig fortran gdbm geoip geolocation gif gimp git gpm iconv icu inotify ipv6 jack java jpeg jpeg2k kde kerberos kipi kpathsea lame lcms ldap libnotify libsamplerate lirc lm_sensors lzma mad matroska mikmod mmx mng mp3 mp4 mpeg msn mtp mudflap multilib mysql ncurses nls nptl ntp ogg openal opencore-amr openexr opengl openmp oscar pam pam_krb5 pango pcre pdf perl phonon plasma png policykit postgres ppds pppd qt3support qt4 quicktime readline rss samba sasl scanner sdl semantic-desktop session smp sndfile snmp speex spell sqlite sse sse2 sse3 ssl startup-notification svg systemd tcpd themes theora threads tiff truetype udev udisks unicode upower usb usrmerge v4l v4l2 vcd vdpau vhosts vim-syntax vorbis vpx webkit wxwidgets x264 xattr xcb xcomposite xine xinerama xml xmp xosd xscreensaver xv xvid xvmc yahoo zeroconf zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" DRACUT_MODULES="systemd crypt lvm mdraid plymouth" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="evdev wacom joystick" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="de en" LIRC_DEVICES="devinput" PHP_TARGETS="php5-3" PYTHON_TARGETS="python3_2 python2_7" QEMU_SOFTMMU_TARGETS="i386 x86_64" RUBY_TARGETS="ruby18 ruby19" USERLAND="GNU" VIDEO_CARDS="nouveau" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
Comment 1 Malte Starostik 2012-10-01 21:48:57 UTC
Created attachment 325498 [details, diff]
remmina-1.0.0_p20120309-fix-avahi.patch

As stated before, this fixes the issue, but I haven't got a clue why or what's going on at all.
Comment 2 Malte Starostik 2012-10-01 21:50:59 UTC
Created attachment 325500 [details]
Build log with original package

As far as I understand cmake's output, avahi is properly detected.  But -DHAVE_LIBAVAHI_{CLIENT,UI} is missing from the compiler flags
Comment 3 Malte Starostik 2012-10-01 21:52:25 UTC
Created attachment 325504 [details]
Build log with patch applied

This one gets the flags and the avahi features are available in the resulting binary.
Comment 4 Mike Gilbert gentoo-dev 2012-10-02 14:50:13 UTC
Please submit your patch upstream

https://github.com/FreeRDP/Remmina
Comment 5 Malte Starostik 2012-10-02 20:01:34 UTC
For reference, upstream issue: https://github.com/FreeRDP/Remmina/issues/113
Comment 6 Malte Starostik 2012-10-03 14:47:18 UTC
Created attachment 325594 [details, diff]
Complete fix as applied upstream

Modified patch combines 35cb796108 and e354cd2038 from upstream and works fine.  Maybe this could be added to portage as -9999 doesn't build with ~arch freerdp and freerdp-9999 doesn't build at all?
Comment 7 Mike Gilbert gentoo-dev 2012-10-07 00:34:59 UTC
I have added new freerdp and remmina snapshots that should take care of this.