Bug 436616 – media-gfx/gimp: use einfo instead of elog when cleaning locales

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Pacho Ramos 2012-09-29 19:56:06 UTC]

This function is needed because gimp needs to manually clean unwanted locales, probably would be enough then to show information with "einfo" instead of "elog" to not contribute to flow summary.log with useless entries:

_clean_up_locales() {
        elog "Cleaning up locales..."
        for lang in ${LANGS}; do
                use "linguas_${lang}" && {
                        elog "- keeping ${lang}"
                        continue
                }
                rm -Rf "${D}"/usr/share/locale/"${lang}" || die
        done
}


Reproducible: Always

[Comment 1 Sebastian Pipping 2012-09-29 20:11:05 UTC]

I don't care too much, but I'm happy to fix it for you.


+  29 Sep 2012; Sebastian Pipping <[e-mail]> gimp-2.6.12-r2.ebuild,
+  gimp-2.6.12-r4.ebuild, gimp-2.6.12-r5.ebuild, gimp-2.8.2.ebuild:
+  Use einfo() rather than elog() to report about cleaning of locales (bug
+  #436616)
+

[Comment 2 Pacho Ramos 2012-09-29 21:27:54 UTC]

Thanks a lot :)

[Comment 3 Rafał Mużyło 2012-09-29 21:41:11 UTC]

Just a minor thing: are you sure this hack is still required in gimp 2.8 in the first place ?

Personally, I've installed from an ebuild with this hack removed and only requested were installed.
Also, while I doubt new translations are often added to gimp by this date, does anyone verifies it, cause this hack requires such check on each release ?

Bug 416597 makes no note if it was checked *why* additional locales were installed.

[Comment 4 Sebastian Pipping 2012-09-30 00:31:59 UTC]

(In reply to comment #3)
> Just a minor thing: are you sure this hack is still required in gimp 2.8 in
> the first place ?
> 
> Personally, I've installed from an ebuild with this hack removed and only
> requested were installed.

Afaik, yes.  I'm happy to resolve _clean_up_locales() if you find anything that does the job in upstream's build system.  In that case, please open a new bug and elaborate on these findings.


> Also, while I doubt new translations are often added to gimp by this date,
> does anyone verifies it, cause this hack requires such check on each release
> ?

I don't see why looking for new locales on each release should be necessary.


> Bug 416597 makes no note if it was checked *why* additional locales were
> installed.

Afair all locales are installed by upstream default.

[Comment 5 Rafał Mużyło 2012-09-30 07:52:17 UTC]

(In reply to comment #4)
> > Bug 416597 makes no note if it was checked *why* additional locales were
> > installed.
> 
> Afair all locales are installed by upstream default.

huh ?
That's not quite true.

As in any intltool managed project (and IIRC same goes for plain gettext), value of LINGUAS determines installed locales - if it's unset, all translations get installed, otherwise - only requested are.