Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 43563 - games-strategy/triplea-0.3.3.ebuild (New Package)
Summary: games-strategy/triplea-0.3.3.ebuild (New Package)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2004-03-02 23:01 UTC by Will McQueen
Modified: 2011-09-14 20:37 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
triplea-0.3.3.ebuild (triplea-0.3.3.ebuild,1.82 KB, text/plain)
2004-03-02 23:02 UTC, Will McQueen
Details
Patch to change saved games dir to ~/.triplea/savedGames (triplea-savedgamesdir.patch,995 bytes, patch)
2004-03-02 23:02 UTC, Will McQueen
Details | Diff
0.4.8 to 0.4.8-r1 diff with savedGames option (triplea-0.4.8-r1.diff,598 bytes, text/plain)
2004-07-07 21:39 UTC, Will McQueen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Will McQueen 2004-03-02 23:01:29 UTC
TripleA is an open source clone of the popular Axis and Allies boardgame.  It's written in Java and built using Ant.

I took the liberty of modifying (via a patch) the saved games directory from the installation directory to (~/.triplea/savedGames).  I also jar'ed up the classes directory for simplification purposes.

Criticism of my ebuild style/technique is appreciated.

Reproducible: Always
Steps to Reproduce:
Comment 1 Will McQueen 2004-03-02 23:02:04 UTC
Created attachment 26747 [details]
triplea-0.3.3.ebuild
Comment 2 Will McQueen 2004-03-02 23:02:39 UTC
Created attachment 26748 [details, diff]
Patch to change saved games dir to ~/.triplea/savedGames
Comment 3 Mr. Bones. (RETIRED) gentoo-dev 2004-03-09 02:30:59 UTC
Quality ebuild.  Just a few minor comments:

trim trailing whitespace
dodir takes a list of directories, no need to call it multiple times
prefer sed to patch for small changes like this one
always stack depends vertically so they're easier to see
don't name the package again in the DESCRIPTION.  so, "A game..." instead of
     "Foo is a game..."
use unpack ${A} to unpack sources in the general case

When I first tried this ebuild, it failed to compile because I was missing junit
from my system.  Be sure to comb over the deps that are needed to build a
package successfully.

I touched up the ebuild and added it as games-strategy/triplea to CVS.  I
didn't test it with jikes since I don't have it installed, so it's in testing
until there's some additional feedback from someone who has jikes in their
USE flags.
Comment 4 Mr. Bones. (RETIRED) gentoo-dev 2004-03-30 03:10:32 UTC
Seems to be working for people.  I went ahead and marked it stable in portage.
Comment 5 Mr. Bones. (RETIRED) gentoo-dev 2004-06-10 00:50:52 UTC
Will - wanna take a shot at getting 0.4.8 working?  I don't know java well
enough to make it work and they've changed the code around upstream.
Comment 6 Will McQueen 2004-06-10 07:36:08 UTC
Sure.  I should have some time this weekend, I'll see how far I can get.
Comment 7 Will McQueen 2004-07-07 21:39:06 UTC
Created attachment 34977 [details]
0.4.8 to 0.4.8-r1 diff with savedGames option

This is a diff of the 0.4.8 ebuild that will create a file called
triplea.properties and stick it in the data dir.

This will default triplea's savedGames dir to the users home directory.
Sorry it took so long for me to get to it.
Comment 8 Will McQueen 2004-07-07 21:40:49 UTC
Whoops, that diff is backwards.  I think I need to go to bed now.  :)
Comment 9 Mr. Bones. (RETIRED) gentoo-dev 2011-09-14 20:37:51 UTC
clean up bug list after bugzilla update