Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 435520 - media-video/kffmpegthumbnailer-1.1.0-r1 ignores cached thumbnails
Summary: media-video/kffmpegthumbnailer-1.1.0-r1 ignores cached thumbnails
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Chris Reffett (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-19 16:21 UTC by Chema
Modified: 2012-09-20 09:55 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chema 2012-09-19 16:21:20 UTC
The thumbnails are created EVERY time that the folder containing the video files is accesed, insted of using the cached thumbnails.

This behaviour goes back to normal after downgrading to version 1.1.0, so the problem is in the ebuild.

Reproducible: Always

Steps to Reproduce:
1.emerge kffmpegthumbnailer-1.1.0-r1
2.enable video thumbnails in dolphin
3.go to a folder with videos
Actual Results:  
Recreates the thumbnails

Expected Results:  
Use the cached ones

Ebuild section at fault:

 	src_prepare() {
 	sed -e "s:CacheThumbnail:X-CacheThumbnail:" \
 	-e "s:IgnoreMaximumSize:X-IgnoreMaximumSize:" \
 	-e "s:ThumbnailerVersion:X-ThumbnailerVersion:" \
 	-e "/Encoding=UTF-8/d" \
 	-i kffmpegthumbnailer.desktop || die "fixing .desktop file failed"
 	kde4-base_src_prepare
 	}

I think this is the culprit: s:CacheThumbnail:X-CacheThumbnail:
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2012-09-20 09:30:20 UTC
The .desktop file was altered without making the rest of the package's code compatible with the change

*kffmpegthumbnailer-1.1.0-r1 (25 Aug 2012)

  25 Aug 2012; Chris Reffett <creffett@gentoo.org>
  +kffmpegthumbnailer-1.1.0-r1.ebuild:
  Bump to EAPI 4, add explicit RDEPEND, fix .desktop validation.

So removing -r1 from Portage as INVALID would solve the problem, nothing for media-video@ to do, reassigining to creffett@gentoo.org for -r1 reverting
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2012-09-20 09:31:11 UTC
As in, you cannot just go around changing .desktop files for them to validate blindly, if unsure, just leave them be
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2012-09-20 09:31:46 UTC
desktop-file-validate is just a guideline and it produces invalid warnings A LOT
Comment 4 Johannes Huber (RETIRED) gentoo-dev 2012-09-20 09:55:21 UTC
Thanks for reporting, should be fine in -r2.

+  20 Sep 2012; Johannes Huber <johu@gentoo.org>
+  +kffmpegthumbnailer-1.1.0-r2.ebuild, -kffmpegthumbnailer-1.1.0-r1.ebuild:
+  Fix the .desktop file regression of last revision, bug #435520.