Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 435272 - net-misc/tigervnc-1.2.0 fails with USE="included-fltk" and has QA issues
Summary: net-misc/tigervnc-1.2.0 fails with USE="included-fltk" and has QA issues
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Raúl Porcel (RETIRED)
URL:
Whiteboard:
Keywords:
: 435300 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-09-16 22:02 UTC by Mike Auty (RETIRED)
Modified: 2012-09-17 14:18 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
tigervnc-1.2.0.ebuild-mycmakeargs.patch (tigervnc-1.2.0.ebuild-mycmakeargs.patch,845 bytes, patch)
2012-09-17 04:29 UTC, Andrey Volkov 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Auty (RETIRED) gentoo-dev 2012-09-16 22:02:13 UTC 
Hiya,

Just filing a bug for the problems I mentioned on IRC.  Currently USE_INCLUDED_FLTK doesn't get passed to configure, because it's only assigned during the src_compile phase, rather than the src_configure phase where it's required.

Including a src_configure as follows should solve the problem:

src_configure() {
    mycmakeargs=(
        -G "Unix Makefiles"
        $(cmake-utils_use_use internal-fltk INCLUDED_FLTK)
        $(cmake-utils_use_enable gnutls GNUTLS)
        $(cmake-utils_use_enable pam PAM)
        $(cmake-utils_use_build java JAVA)
    )

        cmake-utils_src_configure
}


There's also QA warnings given that ebeep and epause don't exist in EAPI4:

* QA Notice: ebeep is not defined in EAPI=4, please file a bug at http://bugs.gentoo.org
 * QA Notice: epause is not defined in EAPI=4, please file a bug at http://bugs.gentoo.org

Just lemme know if you need any further information, or want me to file a separate bug for the QA issues...
Comment 1 Andrey Volkov 2012-09-17 04:29:46 UTC 
Created attachment 324062 [details, diff]
tigervnc-1.2.0.ebuild-mycmakeargs.patch

The same problem here.
And the same solution =)
Comment 2 Raúl Porcel (RETIRED) gentoo-dev 2012-09-17 07:30:59 UTC 
Fixed, sorry i am a bit rusty wrt new EAPIs, i'm old school :P
Comment 3 Raúl Porcel (RETIRED) gentoo-dev 2012-09-17 14:18:52 UTC 
*** Bug 435300 has been marked as a duplicate of this bug. ***