Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 435174 - net-firewall/ipsec-tools suggested init.d improvements
Summary: net-firewall/ipsec-tools suggested init.d improvements
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Anthony Basile
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 435398
  Show dependency tree
 
Reported: 2012-09-16 04:36 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2012-09-19 21:29 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2012-09-16 04:36:33 UTC
With these it's possible to actually have it report a start failure of racoon.

Index: files/racoon.init.d
===================================================================
RCS file: /var/cvsroot/gentoo-x86/net-firewall/ipsec-tools/files/racoon.init.d,v
retrieving revision 1.5
diff -u -B -r1.5 racoon.init.d
--- files/racoon.init.d 21 Apr 2007 12:24:23 -0000      1.5
+++ files/racoon.init.d 16 Sep 2012 04:35:21 -0000
@@ -33,22 +33,20 @@
        fi
 }
 
-start() {
+command=/usr/sbin/racoon
+command_args="-f ${RACOON_CONF} ${RACOON_OPTS}"
+pidfile=/var/run/racoon.pid
+
+start_pre() {
        checkconfig || return 1
        einfo "Loading ipsec policies from ${SETKEY_CONF}."
        /usr/sbin/setkey -f ${SETKEY_CONF}
        if [ $? -eq 1 ] ; then
                eerror "Error while loading ipsec policies"
        fi
-       ebegin "Starting racoon"
-       start-stop-daemon -S -x /usr/sbin/racoon -- -f ${RACOON_CONF} ${RACOON_OPTS}
-       eend $?
 }
 
-stop() {
-       ebegin "Stopping racoon"
-       start-stop-daemon -K -p /var/run/racoon.pid
-       eend $?
+stop_post() {
        if [ -n "${RACOON_RESET_TABLES}" ]; then
                ebegin "Flushing policy entries"
                /usr/sbin/setkey -F
Comment 1 Anthony Basile gentoo-dev 2012-09-16 17:56:39 UTC
Okay I added this with ipsec-tools-0.8.0-r4 (rev bumped from -r3 which is currently stable).  Reopen if there is still some issue.  I'll stabilize in a month and push the change down to the users.
Comment 2 Anthony Basile gentoo-dev 2012-09-18 12:49:49 UTC
There's a problem, see bug #435398.