Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 434626 - sys-fs/udev-189: please use maximum number of allowed characters for elog messages
Summary: sys-fs/udev-189: please use maximum number of allowed characters for elog mes...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal trivial (vote)
Assignee: udev maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-10 18:37 UTC by Pacho Ramos
Modified: 2013-01-18 00:46 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2012-09-10 18:37:22 UTC
Currently looks like every paragraph uses different maximum of words per line:

WARN: postinst

If you build an initramfs including udev, then please
make sure the /usr/bin/udevadm binary gets included,

and your scripts changed to use it,as it replaces the
old helper apps udevinfo, udevtrigger, ...

mount options for directory /dev are no longer
set in /etc/udev/udev.conf, but in /etc/fstab
as for other directories.

Rules for /dev/hd* devices have been removed
Please migrate to libata.

action_modeswitch has been removed by upstream.
Please use sys-apps/usb_modeswitch.

The udev-acl functionality has been removed from standalone udev.
If you are using standalone udev, consolekit handles this
functionality.

This version of udev moves the files that were installed in
/lib/udev to /usr/lib/udev.
We include a backward compatibility patch for gentoo to
allow the rules in /lib/udev/rules.d to be read. However,
bugs should be filed against packages that are installing
files in /lib/udev so they can be fixed.

You need to restart udev as soon as possible to make the upgrade go
into affect.
The method you use to do this depends on your init system.

Upstream has removed the persistent-net and persistent-cd rules
generator. If you need persistent names for these devices,
place udev rules for them in /etc/udev/rules.d.
____________

I think we should try to use as many words per line as possible (maximum is 80, no?)

Also, some small improvements:
"old helper apps udevinfo, udevtrigger, ..." -> at least in spanish, "..." shouldn't be placed after "," it should simply be:
"old helper apps udevinfo, udevtrigger..."

not sure if it's the same in english ;)


"Rules for /dev/hd* devices have been removed
Please migrate to libata." -> a dot is missing after "removed"


I can do the change myself if you let me (and confirm me the maximum number of words per line allowed per policy)

Thanks


Reproducible: Always
Comment 1 William Hubbs gentoo-dev 2012-09-10 22:50:13 UTC
I have cleaned up the ewarns a bit and attempted to reformat them.

Actually the policy is that the lines of code in the ebuild should not
be wider than 80 characters.

Please re-open if this did not clean it up.
Comment 2 Pacho Ramos gentoo-dev 2012-09-11 19:13:06 UTC
Thanks a lot, only a few suggestions:
[...]

Rules for /dev/hd* devices have been removed.
Please migrate to libata.
[...]

-> I am sure I already disable that support in kernel and moved to /dev/sd* long time ago, probably this message should only be shown when old kernel config option is activated 

[...]

The udev-acl functionality has been moved.
If you are not using systemd, this is handled by consolekit.
Otherwise, you need to make sure that systemd is emerged with
the acl use flag active.
[...]

-> Why don't add a dep on "acl? ( || ( sys-auth/consolekit[acl] sys-apps/systemd[acl] )

[...]

This version of udev moves the files which were installed in
/lib/udev to /usr/lib/udev. We include a backward compatibility
patch for gentoo to allow the rules in /lib/udev/rules.d to be
read; however, bugs should be filed against packages which are
installing things in /lib/udev so they can be fixed.
[...]

-> Maybe we could ask portage maintainers to show a QA warning when a package installs files inside old location, what do you think?

[...]

You need to restart udev as soon as possible to make the upgrade go
into affect.
The method you use to do this depends on your init system.
[...]

-> This looks a bit confusing to me, I use openrc but still simply reboot my system to do that, should I simply try to restart udev service?

Thanks and sorry for telling this issues now instead of yesterday, I forgot them probably because I am a bit busy now :(
Comment 3 William Hubbs gentoo-dev 2012-09-11 22:26:52 UTC
(In reply to comment #2)
> Thanks a lot, only a few suggestions:
> [...]
> 
> Rules for /dev/hd* devices have been removed.
> Please migrate to libata.
> [...]
> 
> -> I am sure I already disable that support in kernel and moved to /dev/sd*
> long time ago, probably this message should only be shown when old kernel
> config option is activated 

Which config option are you referring to?

> [...]
> 
> The udev-acl functionality has been moved.
> If you are not using systemd, this is handled by consolekit.
> Otherwise, you need to make sure that systemd is emerged with
> the acl use flag active.
> [...]
> 
> -> Why don't add a dep on "acl? ( || ( sys-auth/consolekit[acl]
> sys-apps/systemd[acl] )

This is one of those situations that isn't really a dependency. Udev runs fine with the acl use flag turned on, regardless of whether consolekit[acl], systemd[acl] or neither is installed. If I added a dependency it would be a runtime dependency, but it isn't even that, because udev runs fine either way.

> [...]
> 
> This version of udev moves the files which were installed in
> /lib/udev to /usr/lib/udev. We include a backward compatibility
> patch for gentoo to allow the rules in /lib/udev/rules.d to be
> read; however, bugs should be filed against packages which are
> installing things in /lib/udev so they can be fixed.
> [...]
> 
> -> Maybe we could ask portage maintainers to show a QA warning when a
> package installs files inside old location, what do you think?

Maybe, but I would rather not request that until this udev is stabilized.

> [...]
> 
> You need to restart udev as soon as possible to make the upgrade go
> into affect.
> The method you use to do this depends on your init system.
> [...]
> 
> -> This looks a bit confusing to me, I use openrc but still simply reboot my
> system to do that, should I simply try to restart udev service?

Right, you can use rc-service udev restart.

> Thanks and sorry for telling this issues now instead of yesterday, I forgot
> them probably because I am a bit busy now :(

Not a problem. :-)  Did I answer all of your questions ok?
Comment 4 Pacho Ramos gentoo-dev 2012-09-12 07:12:55 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > Thanks a lot, only a few suggestions:
> > [...]
> > 
> > Rules for /dev/hd* devices have been removed.
> > Please migrate to libata.
> > [...]
> > 
> > -> I am sure I already disable that support in kernel and moved to /dev/sd*
> > long time ago, probably this message should only be shown when old kernel
> > config option is activated 
> 
> Which config option are you referring to?

I think it's CONFIG_IDE, that is deprecated and people should migrate

> 
> > [...]
> > 
> > The udev-acl functionality has been moved.
> > If you are not using systemd, this is handled by consolekit.
> > Otherwise, you need to make sure that systemd is emerged with
> > the acl use flag active.
> > [...]
> > 
> > -> Why don't add a dep on "acl? ( || ( sys-auth/consolekit[acl]
> > sys-apps/systemd[acl] )
> 
> This is one of those situations that isn't really a dependency. Udev runs
> fine with the acl use flag turned on, regardless of whether consolekit[acl],
> systemd[acl] or neither is installed. If I added a dependency it would be a
> runtime dependency, but it isn't even that, because udev runs fine either
> way.
> 

OK, fine as-is then

> > [...]
> > 
> > This version of udev moves the files which were installed in
> > /lib/udev to /usr/lib/udev. We include a backward compatibility
> > patch for gentoo to allow the rules in /lib/udev/rules.d to be
> > read; however, bugs should be filed against packages which are
> > installing things in /lib/udev so they can be fixed.
> > [...]
> > 
> > -> Maybe we could ask portage maintainers to show a QA warning when a
> > package installs files inside old location, what do you think?
> 
> Maybe, but I would rather not request that until this udev is stabilized.
> 

OK

> > [...]
> > 
> > You need to restart udev as soon as possible to make the upgrade go
> > into affect.
> > The method you use to do this depends on your init system.
> > [...]
> > 
> > -> This looks a bit confusing to me, I use openrc but still simply reboot my
> > system to do that, should I simply try to restart udev service?
> 
> Right, you can use rc-service udev restart.
> 

Thanks for the info

> > Thanks and sorry for telling this issues now instead of yesterday, I forgot
> > them probably because I am a bit busy now :(
> 
> Not a problem. :-)  Did I answer all of your questions ok?
Comment 5 Samuli Suominen (RETIRED) gentoo-dev 2013-01-18 00:46:42 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > Thanks a lot, only a few suggestions:
> > > [...]
> > > 
> > > Rules for /dev/hd* devices have been removed.
> > > Please migrate to libata.
> > > [...]
> > > 
> > > -> I am sure I already disable that support in kernel and moved to /dev/sd*
> > > long time ago, probably this message should only be shown when old kernel
> > > config option is activated 
> > 
> > Which config option are you referring to?
> 
> I think it's CONFIG_IDE, that is deprecated and people should migrate

The warning is long gone from stabilization target >=sys-fs/udev-197-r2.

It seems there is not much left to do here?