Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 43341 - eutils.eclass - make_desktop_entry does not accept full paths to binary
Summary: eutils.eclass - make_desktop_entry does not accept full paths to binary
Status: RESOLVED WONTFIX
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core - Ebuild Support (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-02-29 19:26 UTC by Jeremy Huddleston (RETIRED)
Modified: 2007-01-31 04:01 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Huddleston (RETIRED) gentoo-dev 2004-02-29 19:26:38 UTC
I would expect this to be valid:
make_desktop_entry /usr/bin/xmms ...

But I get:
/usr/sbin/ebuild.sh: line 735: /var/tmp/portage/xmms-1.2.10-r1/temp//usr/bin/xmms.desktop: No such file or directory
install: cannot stat `/var/tmp/portage/xmms-1.2.10-r1/temp//usr/bin/xmms.desktop': No such file or directory
install: cannot stat `/var/tmp/portage/xmms-1.2.10-r1/temp//usr/bin/xmms.desktop': No such file or directory

Changing the $desktop definition to:
local desktop="${T}/`basename ${exec}`.desktop"

and adding basename wherever else is appropriate should fix it.
Comment 1 SpanKY gentoo-dev 2004-02-29 19:30:26 UTC
make_desktop_entry is just a band-aid until the domenu stuff is done

i wrote it and dont really like 'fixing' anything about it ;)
Comment 2 Jeremy Huddleston (RETIRED) gentoo-dev 2004-02-29 19:35:59 UTC
Also, the $subdir setting seems to be undocumented in man and the comments.
local subdir="${6}"
Comment 3 Jeremy Huddleston (RETIRED) gentoo-dev 2004-02-29 19:36:14 UTC
alright then ;)
Comment 4 Boris 2004-06-22 14:10:41 UTC
I found a _very_ minor mistake in this function so I did not file an extra bug for this.

The link [1] in the comment-header of the function make_desktop_entry ist out of date, it now should be something like [2].

As said before very minor, but useful if you want so use the funktion and/or look something up. Would be nice to be fixed, but is not a must-do.


[1] http://www.freedesktop.org/standards/menu/draft/menu-spec/menu-spec.html
[2] http://www.freedesktop.org/standards/menu-spec/
Comment 5 SpanKY gentoo-dev 2004-06-22 15:36:23 UTC
fixed link
Comment 6 Boris 2004-06-22 23:32:40 UTC
I just saw that link is also wrong in man 5 eutils.eclass.
Did you fix that too for the next portage update?
Comment 7 SpanKY gentoo-dev 2004-06-23 04:44:06 UTC
god you guys are demanding ;)

fixed manpage too
Comment 8 Petteri Räty (RETIRED) gentoo-dev 2005-01-07 15:14:43 UTC
The link is again out of date. This one works:
http://www.freedesktop.org/wiki/Standards_2fmenu_2dspec