Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 433165 - net-misc/mirall requires net-misc/csync with USE="sftp samba"
Summary: net-misc/mirall requires net-misc/csync with USE="sftp samba"
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
: 433181 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-08-29 12:49 UTC by Grzegorz Kowal
Modified: 2012-11-30 05:41 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
DANGEROUS mirall ebuild with use flags (mirall-1.0.5.ebuild,609 bytes, text/plain)
2012-10-04 15:44 UTC, Bash Vi
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Grzegorz Kowal 2012-08-29 12:49:15 UTC
The dependency on sftp or samba in net-misc/csync is forced in the mirall ebuild, but in fact it should be optional. I am not sure about webdav. Mirall works perfectly without sftp and samba.

Reproducible: Always
Comment 1 Tomáš Chvátal (RETIRED) gentoo-dev 2012-09-03 12:37:14 UTC
*** Bug 433181 has been marked as a duplicate of this bug. ***
Comment 2 Tomáš Chvátal (RETIRED) gentoo-dev 2012-09-03 12:38:51 UTC
Well basically you are right, but there are buttons that would fail if you have those features disabled on csync during runtime.

So you can built it without the options, but results might be flaky...
Comment 3 Grzegorz Kowal 2012-09-03 17:09:57 UTC
Thanks Tomáš for pointing this out.

I understand that if mirall is compiled with -samba and -sftp the 'Synchronization Target' window in the 'Add Sync' wizard shouldn't show the choice for the remove destination folder.  Anyway, the verification of the remote folder protocol should be done in csync, since mirall does not know 'a priori' what protocols are supported by csync.

I think that the best option would be to add those three flags 'webdav', 'sftp', and 'samba' to mirall's ebuild, and simply pass the dependencies to csync, without forcing the user to install samba, for example, which he is not gonna use anyway.
Comment 4 Bash Vi 2012-10-04 15:44:20 UTC
Created attachment 325646 [details]
DANGEROUS mirall ebuild with use flags

mirall ebuild with use flags. The won't do anything though!
Comment 5 Bash Vi 2012-10-04 15:44:51 UTC
I've encountered the same problem and looked a bit into it.
To me it seems that in mirall, it's not as easy to turn off certain features at compile time as it is in csync. But I might be mistaken, as I haven't got any experiences with cmake.

But I've written an ebuild for mirall that has several useflags. Not turning them on or off, won't do ANYTHING at all, except passing it to csync.
This ebuild is clearly not for serious use. But it allows you to get rid of the unwanted dependencies :)
Comment 6 Chris Reffett (RETIRED) gentoo-dev Security 2012-11-30 05:41:16 UTC
+*mirall-1.1.1-r1 (30 Nov 2012)
+
+  30 Nov 2012; Chris Reffett <creffett@gentoo.org> +mirall-1.1.1-r1.ebuild,
+  -mirall-1.1.1.ebuild, metadata.xml:
+  Add USE-conditional deps on csync USE flags wrt bug 433165
+

Committed to CVS, have fun.