Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 433100 - prefix portage: has legacy exception handling code
Summary: prefix portage: has legacy exception handling code
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All All
: Normal minor (vote)
Assignee: Gentoo Prefix
URL: http://prefix.gentooexperimental.org:...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-28 21:13 UTC by Greg Turner
Modified: 2012-09-29 15:22 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
rewrite troublesome exception handling syntax (py3-exception-handling.patch,1.00 KB, patch)
2012-08-28 21:14 UTC, Greg Turner
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Turner 2012-08-28 21:13:13 UTC
I am presuming that portage has decided to abandon the annoyingly python3-incompatible "except Class, varname" syntax, hence its removal in master; we still have a couple in prefix.

Reproducible: Always

Steps to Reproduce:
find . -name '*.py' |xargs grep -C0 -n --color=no 'except [^[:space:][:punct:]]*,' | tee /dev/stderr | wc -l
Actual Results:  
./pym/_emerge/actions.py:2478:                  except OSError, e:
./pym/_emerge/actions.py:2504:          except IOError, e:
2


patch enclosed
Comment 1 Greg Turner 2012-08-28 21:14:21 UTC
Created attachment 322480 [details, diff]
rewrite troublesome exception handling syntax
Comment 2 Greg Turner 2012-08-28 21:17:28 UTC
nb: the above is a patch against the prefix branch (of git://git.overlays.gentoo.org/proj/portage.git)
Comment 3 Fabian Groffen gentoo-dev 2012-09-06 18:17:06 UTC
thanks, patch applied
Comment 4 Fabian Groffen gentoo-dev 2012-09-29 15:22:29 UTC
was released in the meanwhile