Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 432838 - games-board/aisleriot uses games.eclass incorrectly
Summary: games-board/aisleriot uses games.eclass incorrectly
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-26 11:50 UTC by Julian Ospald
Modified: 2012-08-26 15:43 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
aisleriot-3.4.1-r1.ebuild (aisleriot-3.4.1-r1.ebuild,2.30 KB, text/plain)
2012-08-26 15:17 UTC, Alexandre Rostovtsev (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Ospald 2012-08-26 11:50:40 UTC
games.eclass has a few policies on how to use it. games-board/aisleriot does ignore almost all of them, including missing games_pkg_setup, missing prepgamesdirs, missing games_pkg_postinst and not inheriting it last.

I suggest to go for review in #gentoo-games.
Comment 1 Julian Ospald 2012-08-26 12:33:28 UTC
games variables (e.g. install destinations) are also ignored
Comment 2 Alexandre Rostovtsev (RETIRED) gentoo-dev 2012-08-26 15:17:23 UTC
Created attachment 322276 [details]
aisleriot-3.4.1-r1.ebuild

> not inheriting it last

aisleriot is first and foremost a gnome application which is maintained by the gnome team. We want gnome2.eclass to provide the default phase functions. Sorry.

> games variables (e.g. install destinations) are also ignored

aisleriot is a gnome application and must use some standard install locations to interact with the rest of gnome. For example, gnome3 help files must go in /usr/share/help, gconf schemas must go in /etc/gconf, glib schemas go in /usr/share/glib-2.0, etc.

As for the rest of the comments, please take a look at the attached ebuild.
Comment 3 Alexandre Rostovtsev (RETIRED) gentoo-dev 2012-08-26 15:43:38 UTC
Should be fixed now.

>*aisleriot-3.4.1-r1 (26 Aug 2012)
>*aisleriot-3.2.3.2-r1 (26 Aug 2012)
>
>  26 Aug 2012; Alexandre Rostovtsev <tetromino@gentoo.org>
>  -aisleriot-3.2.3.1.ebuild, +aisleriot-3.2.3.2-r1.ebuild,
>  +aisleriot-3.4.1-r1.ebuild:
>  Use games_pkg_setup, prepgamesdirs, and those games install locations which
>  are possible for a gnome application; bug #432838, thanks to Julian Ospald
>  (hasufell). Drop old.