Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 43245 - There should be an init script for svnserve in the subversion ebuild
Summary: There should be an init script for svnserve in the subversion ebuild
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Paul de Vrieze (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-02-28 20:30 UTC by Martin Jackson (RETIRED)
Modified: 2020-03-14 21:33 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Initscript for svnserve (svnserve,506 bytes, text/plain)
2004-02-28 21:04 UTC, Martin Jackson (RETIRED)
Details
conf.d file to go with the init script (svnserve,314 bytes, text/plain)
2004-02-28 21:05 UTC, Martin Jackson (RETIRED)
Details
modified initscript for svnserve (svnserve,548 bytes, text/plain)
2004-03-01 08:43 UTC, Joby Walker
Details
modified conf.d config file (svnserve,441 bytes, text/plain)
2004-03-01 08:47 UTC, Joby Walker
Details
xinetd.d conf file for svnserve (svnserve,290 bytes, text/plain)
2004-03-15 20:51 UTC, Martin Jackson (RETIRED)
Details
patch for proper xinetd support (subversion-1.5.6.ebuild.patch,1.14 KB, patch)
2009-05-22 15:20 UTC, ta2002
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Jackson (RETIRED) gentoo-dev 2004-02-28 20:30:27 UTC
There should be a svnserve init script for people who choose not to use the Apache2 interface.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Martin Jackson (RETIRED) gentoo-dev 2004-02-28 21:04:42 UTC
Created attachment 26551 [details]
Initscript for svnserve

This is an example initscript.	svnserve seems a little odd in not writing its
own pidfile, so in this initscript I'm doing some weird stuff in start() to get
it to register properly.  If there's a better way, feel free to fix it.  There
will also be an /etc/conf.d file.
Comment 2 Martin Jackson (RETIRED) gentoo-dev 2004-02-28 21:05:38 UTC
Created attachment 26552 [details]
conf.d file to go with the init script

conf.d file to supply svnserve arguments
Comment 3 Joby Walker 2004-03-01 08:37:57 UTC
I've added a bit more to the initial scripts so that the pid location is adjustable (makes it easier if you want to run multiple daemons) and so that the daemon can run as non-root.
Comment 4 Joby Walker 2004-03-01 08:43:16 UTC
Created attachment 26660 [details]
modified initscript for svnserve

The pid file location and the user/group that svnserver runs under are now
adjustable in the conf.d file.
Comment 5 Joby Walker 2004-03-01 08:47:51 UTC
Created attachment 26661 [details]
modified conf.d config file

Three new variables: 1) pidfile location, 2) user for the daemon, 3) group for
the daemon.  I also set a default "--listen-host=localhost" to make the daemon
more secure if run unmodified.
Comment 6 Martin Jackson (RETIRED) gentoo-dev 2004-03-15 20:51:00 UTC
Created attachment 27429 [details]
xinetd.d conf file for svnserve

xinetd config file for svnserve.  Disabled by default.
Comment 7 Aron Griffis (RETIRED) gentoo-dev 2004-11-12 10:51:22 UTC
Fixed in 1.1.1-r2

Notes:
- I kept Joby's changes wrt user and group setting in conf.d/svnserve, but changed the defaults to apache:apache since that's what the subversion ebuild defaults to using.
- I removed the pidfile setting since you can't start an init-script more than once anyway.  If you want to run multiple servers via init-scripts, you'll have to make a copy of the init-script, and at that point you're on your own.
- I changed the xinetd snippet to run the server as apache:apache and log to syslog instead of a custom file.
Comment 8 ta2002 2009-05-22 15:18:23 UTC
Should parts of this be revisited?

It seems wrong to me to create an xinetd,d directory without requiring (or even checking for) xinetd to be installed.

I would suggest adding the xinetd use flag, and then testing for it.

I think I could even come up with a patch that does that.
Comment 9 ta2002 2009-05-22 15:20:37 UTC
Created attachment 192124 [details, diff]
patch for proper xinetd support
Comment 10 Jaak Ristioja 2020-03-14 21:33:45 UTC
See also https://github.com/gentoo/gentoo/pull/14956