Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 432388 - dev-vcs/git - make app-text/highlight dependency optional
Summary: dev-vcs/git - make app-text/highlight dependency optional
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-23 07:42 UTC by Guillaume Castagnino
Modified: 2012-08-25 08:31 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Guillaume Castagnino 2012-08-23 07:42:53 UTC
New git ebuild ask for highlight dependency when building the CGI.

This depend should be optional: the CGI do NOT enable the highlight support by default. Quoting the cgi script (at line 520):
=========8<=========
    # Syntax highlighting support. This is based on Daniel Svensson's
    # and Sham Chukoury's work in gitweb-xmms2.git.
    # It requires the 'highlight' program present in $PATH,
    # and therefore is disabled by default.

    # To enable system wide have in $GITWEB_CONFIG
    # $feature{'highlight'}{'default'} = [1];

    'highlight' => {
        'sub' => sub { feature_bool('highlight', @_) },
        'override' => 0,
        'default' => [0]},
=========>8=========

My point is that app-text/highlight is a *huge* dependency, because it brings dev-libs/boost (huge lib that requires a lot of memory to compile, not tailored for small servers where gitweb can be hosted).
For me it's a too big depend just for some fancy (and optional) colors.
So please, make it optional !

Thanks
Comment 1 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2012-08-23 20:18:33 UTC
InCVS.
Comment 2 Stefan Richter 2012-08-24 18:55:58 UTC
portage-20120823 is broken.

I have currently dev-vcs/git-1.7.10.2 installed, due to
   <=dev-vcs/git-1.7.10.99 **
in /etc/portage/package.keywords.  (That's because 1.7.10 is required for proper support of pulling tags and showing gpg signatures in merge messages.)

But suddenly, emerge -uav world wnats to downgrade to dev-vcs/git-1.7.8.6.  The reason:
-------------------------------------------------------------------------
# emerge -av =dev-vcs/git-1.7.10.2

These are the packages that would be merged, in order:

Calculating dependencies... done!

!!! All ebuilds that could satisfy "=dev-vcs/git-1.7.10.2" have been masked.
!!! One of the following masked packages is required to complete your request:
- dev-vcs/git-1.7.10.2::gentoo (masked by: invalid: RDEPEND: USE flag 'highlight' referenced in conditional 'highlight?' is not in IUSE)

For more information, see the MASKED PACKAGES section in the emerge
man page or refer to the Gentoo Handbook.
-------------------------------------------------------------------------

So, what now?
Comment 3 Guillaume Castagnino 2012-08-24 19:41:21 UTC
This has already been fixed in tree, just resync your portage tree !

Here : http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/dev-vcs/git/git-1.7.12-r2.ebuild?r1=1.2&r2=1.3
Comment 4 Stefan Richter 2012-08-25 08:31:40 UTC
Indeed, works for me now. Thanks.