Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 432328 - dev-vcs/git-1.7.12-r1: __git_ps1 has gone from bash-completion
Summary: dev-vcs/git-1.7.12-r1: __git_ps1 has gone from bash-completion
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords:
: 432416 432600 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-08-22 17:28 UTC by Alex Muenn
Modified: 2012-08-24 15:17 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
original git-core file containing __git_ps1 function (git-prompt.sh,7.96 KB, text/plain)
2012-08-22 17:33 UTC, Alex Muenn
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Muenn 2012-08-22 17:28:25 UTC
After upgrading to latest Git version, bash function __git_ps1 is not available anymore.

Reproducible: Always

Steps to Reproduce:
0. emerge Git with bash-completion enabled
1. enable Git bash-completion module
2. enter a directory under Git version control
3. check completion upon 'git' command
4. __git_* commands should be available but __git_ps1 is missing
X: try to run __git_ps1
Actual Results:  
bash: __git_ps1: command not found

Expected Results:  
Output of active branch, e.g. (master)

Git sources of bash-completion has been changed. Definition of '__git_ps1' function has been moved to a separate file:

from: contrib/completion/git-completion.bash
to:   contrib/completion/git-prompt.sh

I have just executed:

# tail -n+76 contrib/completion/git-prompt.sh >> contrib/completion/git-completion.bash

and replaced completion sources on my system

# cp contrib/completion/git-completion.bash /usr/share/bash-completion/git
Comment 1 Alex Muenn 2012-08-22 17:33:43 UTC
Created attachment 321968 [details]
original git-core file containing __git_ps1 function
Comment 2 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2012-08-23 05:38:22 UTC
Fixed in 1.7.12-r2. You need to enable the new git-prompt script.
Comment 3 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2012-08-23 16:56:53 UTC
*** Bug 432416 has been marked as a duplicate of this bug. ***
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2012-08-24 15:15:49 UTC
*** Bug 432600 has been marked as a duplicate of this bug. ***
Comment 5 Adrian 2012-08-24 15:17:57 UTC
There should be a message informing about the necessary change when emerging one of the newer git versions.