Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 432308 - app-emulation/libvirt-0.9.13-r1 virsh segfaults on snapshot-list
Summary: app-emulation/libvirt-0.9.13-r1 virsh segfaults on snapshot-list
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Doug Goldstein (RETIRED)
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2012-08-22 13:20 UTC by Christian Affolter
Modified: 2012-11-18 07:35 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch against libvirt-0.9.13-r1.ebuild for applying the two patches via epatch (libvirt-0.9.13-r2.patch,592 bytes, patch)
2012-08-22 13:21 UTC, Christian Affolter
Details | Diff
Fill remote parameters in remoteDomainListAllSnapshots() (0.9.13-fill-remote-parameters.patch,831 bytes, patch)
2012-08-22 13:23 UTC, Christian Affolter
Details | Diff
virsh: Fix ordering of arguments when calling vshCalloc. (0.9.13-vshCalloc-arguments-order-fix.patch,1.21 KB, patch)
2012-08-22 13:24 UTC, Christian Affolter
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Affolter 2012-08-22 13:20:28 UTC
'virsh snapshot-list <GUEST>' terminates with a segfault on app-emulation/libvirt-0.9.13-r1

The bug is already fixed upstream, see https://www.redhat.com/archives/libvirt-users/2012-July/msg00048.html

I've successfully applied the two patches mentioned in the above post and after re-installing libvirt the snapshot-list command works again.
Comment 1 Christian Affolter 2012-08-22 13:21:56 UTC
Created attachment 321948 [details, diff]
Patch against libvirt-0.9.13-r1.ebuild for applying the two patches via epatch
Comment 2 Christian Affolter 2012-08-22 13:23:21 UTC
Created attachment 321950 [details, diff]
Fill remote parameters in remoteDomainListAllSnapshots()

This patch fills the domain argument that is sent to the remote side.
This caused a client segfault as the argument was NULL.
Comment 3 Christian Affolter 2012-08-22 13:24:58 UTC
Created attachment 321952 [details, diff]
virsh: Fix ordering of arguments when calling vshCalloc.

In vshSnapshotListCollect() vshCalloc was called with swapped nmemb and
size argument. This caused division by zero in xalloc_oversized as the
macro doesn't expect size to be zero.
Comment 4 Doug Goldstein (RETIRED) gentoo-dev 2012-11-18 07:35:57 UTC
New version is stable where this is fixed.