Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 432174 - www-client/pybugz-0.10.1 convert to distutils-r1
Summary: www-client/pybugz-0.10.1 convert to distutils-r1
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: William Hubbs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-21 11:12 UTC by Michael Weber (RETIRED)
Modified: 2013-10-08 10:05 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
pybugz-0.10.1-r1.ebuild.diff (pybugz-0.10.1-r1.ebuild.diff,1.67 KB, patch)
2013-06-24 22:00 UTC, Julian Ospald
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Weber (RETIRED) gentoo-dev 2012-08-21 11:12:51 UTC
I'm writeing something based on www-client/pybugz and python3,
and i had to discover an suboptimal usage of python.eclass.

Please apply this patch and `ekeword ~all ...` to enable installation for python2.7, 3.1 and 3.2.

Thanks, 

   Michael

--- pybugz-0.10.1.ebuild        2012-06-17 21:01:28.000000000 +0200
+++ pybugz-0.10.1-r1.ebuild     2012-08-21 13:01:51.197032559 +0200
@@ -4,6 +4,8 @@
 
 EAPI=3
 PYTHON_DEPEND="2:2.7"
+RESTRICT_PYTHON_ABIS="2.[56]"
+SUPPORT_PYTHON_ABIS="1"
 PYTHON_MODNAME="bugz"
 PYTHON_USE_WITH="readline"
 
@@ -17,7 +19,7 @@
        S="${WORKDIR}/williamh-pybugz-${GITHUB_COMMIT}"
 fi
 
-inherit $vcs bash-completion-r1 distutils
+inherit $vcs bash-completion-r1 distutils python
 
 DESCRIPTION="Command line interface to (Gentoo) Bugzilla"
 HOMEPAGE="http://www.github.com/williamh/pybugz"
@@ -30,10 +32,6 @@
 
 DOCS="bugzrc.example"
 
-pkg_setup() {
-       python_set_active_version 2.7
-}
-
 src_install() {
        distutils_src_install
Comment 1 Arfrever Frehtes Taifersar Arahesis 2012-08-21 20:41:13 UTC
(In reply to comment #0)
> @@ -17,7 +19,7 @@
>         S="${WORKDIR}/williamh-pybugz-${GITHUB_COMMIT}"
>  fi
>  
> -inherit $vcs bash-completion-r1 distutils
> +inherit $vcs bash-completion-r1 distutils python
>  
>  DESCRIPTION="Command line interface to (Gentoo) Bugzilla"
>  HOMEPAGE="http://www.github.com/williamh/pybugz"

This change should not be made. distutils.eclass is guaranteed to always inherit python.eclass.
Comment 2 Julian Ospald 2013-06-24 22:00:49 UTC
Created attachment 351844 [details, diff]
pybugz-0.10.1-r1.ebuild.diff
Comment 3 Julian Ospald 2013-10-07 00:41:29 UTC
I will fix this as I see fit in 2 weeks if the maintainer does not respond.
Comment 4 William Hubbs gentoo-dev 2013-10-07 06:36:39 UTC
I am responding now; this will be fixed in the next few days.
Comment 5 Julian Ospald 2013-10-07 11:08:51 UTC
thanks
Comment 6 William Hubbs gentoo-dev 2013-10-07 19:44:51 UTC
Is a rev bump necessary for this? If it is I would rather look at git
and see where I am with getting a new release out the door than go
through a revbump/wait 30 days/stabilize for this migration.
Comment 7 Julian Ospald 2013-10-07 19:47:00 UTC
the thing is there is no stable pypy version...
Comment 8 William Hubbs gentoo-dev 2013-10-07 21:58:10 UTC
What if we just convert this to distutils-r1 then I ad pypy support in
the next release, can we convirt in place to distutils-r1 and not worry
about pypy in this release?
Comment 9 Mike Gilbert gentoo-dev 2013-10-07 22:15:42 UTC
(In reply to William Hubbs from comment #8)

If would advise against an in-place conversion for the following reasons:

1. Current ebuild is stable.
2. The set of installed files will change (pyc/pyo files).

Waiting for the next release to do the conversion seems like a reasonable thing to me. PyPy is considered experimental, so this should not be pushed through just for that.
Comment 10 Julian Ospald 2013-10-07 22:26:03 UTC
sure, that's why the diff says -r1

:o
Comment 11 William Hubbs gentoo-dev 2013-10-08 00:27:44 UTC
I am going to agree with Mike here.
The conversion has been done in the 9999 ebuild, so it will be covered
in the next release (0.11.x); I do not see a need to do a revbump for
this.
Comment 12 William Hubbs gentoo-dev 2013-10-08 02:36:23 UTC
I plan to have 0.11 out within 30 days, so I think it would be sort of
redundant to have a ~arch 0.10.x then 0.11 within the same 30 day
window.
Comment 13 Julian Ospald 2013-10-08 10:05:14 UTC
I'd rather set the bug status to IN_PROGRESS then and fix the title.