Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 431600 - x11-libs/cairo doesn't need buggy gradients patch with >=nvidia-drivers-304.37
Summary: x11-libs/cairo doesn't need buggy gradients patch with >=nvidia-drivers-304.37
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Ben de Groot (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-16 07:14 UTC by Mark R. Pariente
Modified: 2012-11-04 09:55 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark R. Pariente 2012-08-16 07:14:49 UTC
The new nvidia drivers (304.37) have fixed the buggy gradient rendering issues. Removing the buggy-gradients patch from cairo 1.12.2-r3 results in a rather nice performance boost, so I think the ebuild for cairo should exclude this patch if the proper nvidia-drivers version (>=304.37) is detected.

Reproducible: Always
Comment 1 Robert Cabrera 2012-08-19 16:22:17 UTC
I agree with the previous poster. Nvidia fixed the bug with 304.37.

I removed the patch from cairo in my overlay and noticed a big performance boost.

Please modify the ebuild so that this patch is no longer installed for all those running nvidia-drivers-304.37 and newer. This will be a positive improvement for all of us using these video cards. TIA
Comment 2 Robert Cabrera 2012-08-19 19:26:25 UTC
I forgot to add in my previous post that my workaround was to copy the cairo-1.12.2-r2.ebuild (which doesn't call the the patch) into my overlay and renamed it cairo-1.12.2-r3 then digest it.

As mentioned, so far all seems fine without the patch and these drivers.
Comment 3 Robert Cabrera 2012-08-19 19:43:02 UTC
Now I feel like an idiot. After posting my last comment I realized that an even easier workaround is to just mask cairo-1.12.2-r3.

Since cairo-1.12.2-r2 is still in the tree, it would then be installed instead.
Comment 4 Doug Goldstein (RETIRED) gentoo-dev 2012-08-29 03:27:06 UTC
Samuli,

Can we get this behavior exposed via a USE flag? Or would upstream be willing to expose this via some X session configuration?
Comment 5 Samuli Suominen (RETIRED) gentoo-dev 2012-11-04 09:55:09 UTC
+  04 Nov 2012; Samuli Suominen <ssuominen@gentoo.org> cairo-1.12.6.ebuild,
+  cairo-9999.ebuild, metadata.xml:
+  Leave -buggy_gradients.patch behind USE="legacy-drivers" for users of, for
+  example, <x11-drivers/nvidia-drivers-304.30.