Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 431578 - app-shells/gentoo-bashcomp - proper support for atoms preceded by equal sign in _pkgname()
Summary: app-shells/gentoo-bashcomp - proper support for atoms preceded by equal sign ...
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Gentoo Shell Tools project
URL:
Whiteboard:
Keywords: PATCH
Depends on: 437932
Blocks:
  Show dependency tree
 
Reported: 2012-08-15 22:48 UTC by Jacek Sowiński
Modified: 2017-06-15 17:10 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
First patch needed to fix support for atoms with 'equal-sign' (0003-Experimental-changes-in-resolving-atoms-preceded-by-.patch,2.10 KB, patch)
2012-08-15 22:48 UTC, Jacek Sowiński
Details | Diff
Second patch to fix support for atoms with 'equal-sign' (0004-Full-I-hope-support-for-atoms-preceded-by-equal-sign.patch,5.87 KB, patch)
2012-08-15 22:49 UTC, Jacek Sowiński
Details | Diff
Remove unneeded variable (0001-Delete-variable-created-for-debug-purposes-only.patch,562 bytes, patch)
2012-08-15 22:57 UTC, Jacek Sowiński
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jacek Sowiński 2012-08-15 22:48:52 UTC
Created attachment 321440 [details, diff]
First patch needed to fix support for atoms with 'equal-sign'

Current support for atoms like =some-category/package-1.23-r1 is broken.
Those 2 patches are fixing it:
     1. Add '=' *automatically* only when completing installed packages
        (`_pkgname -I`).
     2. Don't look for version unless user explicitly wants to do that -
        check if '=' sign is the first char of the atom.
     3. Fix automatic add of '=' in front of the atom - no more
        duplicated equal signs.

I attached 2 patches in the format given by 'git format-patch'.
Comment 1 Jacek Sowiński 2012-08-15 22:49:52 UTC
Created attachment 321442 [details, diff]
Second patch to fix support for atoms with 'equal-sign'
Comment 2 Jacek Sowiński 2012-08-15 22:57:16 UTC
Created attachment 321444 [details, diff]
Remove unneeded variable

By the way, in one of my earlier patches already merged into
main tree I forgot to remove one variable, which was created for my own
debug purposes. Here is a patch to get rid of it.
Comment 3 Ryan Hill (RETIRED) gentoo-dev 2012-10-11 04:26:10 UTC
I also noticed that version completion only works when you use the full cat/pkgname form.  It'd be nice if it worked with just pkgname as well.