431018 – x11-libs/gtk+:2: remove useless setting of GDK_USE_XFT

Bug 431018 - x11-libs/gtk+:2: remove useless setting of GDK_USE_XFT

Summary: x11-libs/gtk+:2: remove useless setting of GDK_USE_XFT

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] GNOME (show other bugs)
Hardware:	All Linux

Importance:	Normal minor (vote)
Assignee:	Gentoo Linux Gnome Desktop Team

URL:
Whiteboard:
Keywords:	Inclusion

Depends on:
Blocks:

Reported:	2012-08-11 22:28 UTC by Hans
Modified:	2012-11-05 01:15 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Hans 2012-08-11 22:28:13 UTC

Currently, all x11-libs/gtk+-2* ebuilds do the following:

        # Enable xft in environment as suggested by <utx@gentoo.org>
        echo "GDK_USE_XFT=1" > "${T}"/50gtk2
        doenvd "${T}"/50gtk2

This has not been doing anything for quite a while:
a) gtk+-2.24.8 (and newer) do not mention it anywhere in their sources except for the changelog
b) this changelog includes:

[...]
commit 60d1ac5539cd57b693920bae695041b156e44f17
Author: Matthias Clasen <mclasen@redhat.com>
Date:   Fri May 21 22:14:46 2010 -0400

    Remove long-obsolete docs

    There are no traces of GDK_USE_XFT, GXID_HOST or GXID_PORT in the
    code anymore.
    (cherry picked from commit 7652c2b3e066b4b68a8ac9fcc6093d13d1e35f66)
[...]

I also confirmed that running with / without having GDK_USE_XFT=1 set makes no difference at all with gtk+-2.24.11-r1.

So please remove this.

Thanks for your work!

Comment 1 Alexandre Rostovtsev (RETIRED) gentoo-dev

2012-11-05 01:15:32 UTC

Thanks, the obsolete env.d file has been removed in 2.24.13-r1

>*gtk+-2.24.13-r1 (05 Nov 2012)
>
>  05 Nov 2012; Alexandre Rostovtsev <tetromino@gentoo.org> gtk+-2.24.12.ebuild,
>  gtk+-2.24.13.ebuild, +gtk+-2.24.13-r1.ebuild,
>  +files/gtk+-2.24.13-gtk3-bookmarks.patch, gtk+-3.4.4.ebuild,
>  +files/gtk+-3.4.4-isnan.patch:
>  Fix 3.4.4 build failure with uclibc (bug #441634, thanks to Anthony Basile).
>  For 2.24.13-r1, share bookmarks with gtk3, and do not install obsolete env.d
>  file (bug #431018, thanks to Hans). UI tests in gtk2 fail if immodules are
>  not already installed (bug #413185, thanks to Patrick Lauer).