Bug 430004 – dev-util/pkgconf uses err.h gnuisms

• Status: RESOLVED FIXED
• Product: Gentoo/Alt

[Description Fabian Groffen 2012-08-05 13:29:23 UTC]

getopt_long.c uses warnx from err.h, which is not available on Solaris

[Comment 1 William Pitcock 2012-08-07 06:31:30 UTC]

Fabian,

Can you send me a patch for this as you mentioned on #pkgconf?  I will get it rolled into a 0.8.6 release.

[Comment 2 Fabian Groffen 2012-08-07 07:45:53 UTC]

before I'm going to implement the full mess of just getting warnx working (it really needs some stuff on Solaris, since also getting the program name is tricky), I'd like to poke you on your opinion to just remove the usage of warnx (it's 6 places or something), and replace it by a simple fprintf(stdout, "pkgconf: %s\n", strerror(errno)); or something

[Comment 3 Fabian Groffen 2012-08-07 07:46:56 UTC]

@nenolod: taking the freedom to CC you, seems we can get in touch through this bug better for the time being

[Comment 4 William Pitcock 2012-08-08 08:53:22 UTC]

Fabian,

warnx() can die.  I just imported that code from NetBSD so that I would have a getopt_long() that I could be sure supported argument permutation.

I would like to avoid using err.h at all, so if you would like to clean all of that up, I would be more than happy to get the patch integrated.

[Comment 5 Fabian Groffen 2012-08-08 08:55:57 UTC]

ok, as soon as my arms/hands allow, I'll nuke it from the code and attach a patch here.

[Comment 6 Fabian Groffen 2012-08-08 13:32:26 UTC]

Created attachment 320696 [details, diff]
pkgconf-no-warnx.patch

Not really a beauty, but the cheapest way to get code without warnx.

[Comment 7 Fabian Groffen 2012-08-14 06:38:45 UTC]

pkgconf-0.8.6 was release with this fix, please bump in tree

[Comment 8 Fabian Groffen 2012-08-20 14:39:08 UTC]

pkgconf just got bumped to 0.8.7