429796 – x11-themes/qtcurve-qt4: windeco does not load with >=kde-4.9

Bug 429796 - x11-themes/qtcurve-qt4: windeco does not load with >=kde-4.9

Summary: x11-themes/qtcurve-qt4: windeco does not load with >=kde-4.9

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Qt Bug Alias

URL:
Whiteboard:
Keywords:	PATCH

Depends on:
Blocks:

Reported:	2012-08-04 12:01 UTC by Franz Trischberger
Modified:	2012-08-04 13:54 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
make kwin-deco-qtcurve load again (qtcurve_kde-4.9_compatibility.patch,512 bytes, text/plain) 2012-08-04 12:01 UTC, Franz Trischberger	Details
only export decoration_version(), if kde >= 4.8.97 is installed (qtcurve_kde-4.9_compatibility.patch,414 bytes, patch) 2012-08-04 13:36 UTC, Franz Trischberger	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Franz Trischberger 2012-08-04 12:01:45 UTC

Created attachment 320280 [details]
make kwin-deco-qtcurve load again

This commit
https://projects.kde.org/projects/kde/kde-workspace/repository/revisions/7abe24039517e50dcda843beac2e5deff5a789b3
prevents the qtcurve-kwin-deco from loading (deco-api-versions do not match).
As the factory-implementation used in qtcurve can not be replaced with what is offered in the KWIN_DECORATION-Macro, IMHO the only solution is to copy the relevant version-part over to qtcurve - which the attached patch does.

I could not find a git-repo for qtcurve to look if this is already fixed.

Comment 1 Johannes Huber (RETIRED) gentoo-dev

2012-08-04 12:05:39 UTC

Does the patch break KDE 4.8?

Comment 2 Franz Trischberger 2012-08-04 13:20:39 UTC

(In reply to comment #1)
> Does the patch break KDE 4.8?
Yes, it will. I could not find KWIN_DECORATION or KWIN_DECORATION_API_VERSION in 4.8.4.

Comment 3 Johannes Huber (RETIRED) gentoo-dev

2012-08-04 13:24:56 UTC

Thank you for the report. This should be fixed in x11-themes/qtcurve-qt4-1.8.13-r1. I have added a patch from chakra linux.

+  04 Aug 2012; Johannes Huber <johu@gentoo.org>
+  +files/qtcurve-qt4_kde49-kwin_decoration-macro.patch,
+  +qtcurve-qt4-1.8.13-r1.ebuild:
+  Revision bump adds chakra patch which fixes loading of windeco wrt bug
+  #429796. Set KDE_MINIMAL version to 4.9. Dropp ppc/ppc64 keywords as KDE 4.9
+  is not keyworded yet. Thanks to Franz Fellner <alpine.art.de@googlemail.com>.

Comment 4 Franz Trischberger 2012-08-04 13:36:52 UTC

Created attachment 320290 [details, diff]
only export decoration_version(), if kde >= 4.8.97 is installed

This *should* fix compilation with <4.8.80.
The ABI-Version was added with this commit:
http://quickgit.kde.org/index.php?p=kde-workspace.git&a=commit&h=5b601dc6d57819cd2fda0c88c83e9cdceb79ba54
I even downloaded the 4.8.80 to check existence of KWIN_DECORATION_API_VERSION ;)

Comment 5 Johannes Huber (RETIRED) gentoo-dev

2012-08-04 13:54:41 UTC

Thanks for your work.

+  04 Aug 2012; Johannes Huber <johu@gentoo.org> +qtcurve-qt4-1.8.13-r2.ebuild,
+  -qtcurve-qt4-1.8.13-r1.ebuild,
+  files/qtcurve-qt4_kde49-kwin_decoration-macro.patch:
+  New revision with updated patch by Franz Fellner
+  <alpine.art.de@googlemail.com> which is compatible with KDE 4.8, bug #429796.
+  Remove old revision, ppc/ppc64 restored.