Bug 429726 – emul-linux-x86-* should not hardcode lib32

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description SpanKY 2012-08-03 20:52:27 UTC]

please use $(get_libdir x86) rather than hardcoding "lib32"

[Comment 1 Pacho Ramos 2012-09-10 18:55:50 UTC]

Not sure what you are referring to, emul packages are precompiled packages to be installed in ${ROOT}usr/lib32 :-/, what do you exactly want to change? :|

Thanks for the explanation :)

[Comment 2 SpanKY 2012-09-10 19:37:48 UTC]

hmm, a few will have paths hardcoded into them to refer to /usr/lib32/ at build time.  most don't care though where they get installed into.

maybe in emul-linux-x86.eclass:src_install do:

local x86_libdir=$(get_libdir x86)
if [[ ${x86_libdir} != "lib32" ]] ; then
    ewarn "Moving lib32/ to ${x86_libdir}/; some libs might not work"
    mv "${D}"/usr/lib32 "${D}"/usr/${x86_libdir} || die
    mv "${D}"/lib32 "${D}"/${x86_libdir} || die
fi

[Comment 3 Pacho Ramos 2012-09-10 20:47:32 UTC]

Will check for next emul set, thanks

[Comment 4 Pacho Ramos 2012-10-28 09:08:46 UTC]

(In reply to comment #2)
> hmm, a few will have paths hardcoded into them to refer to /usr/lib32/ at
> build time.  most don't care though where they get installed into.
> 
> maybe in emul-linux-x86.eclass:src_install do:
> 
> local x86_libdir=$(get_libdir x86)

I need to use:
local x86_libdir=$(ABI=x86 get_libdir)

instead, otherwise it tries to move them to lib64 (on amd64), not sure if that get_libdir behavior is expected...

> if [[ ${x86_libdir} != "lib32" ]] ; then
>     ewarn "Moving lib32/ to ${x86_libdir}/; some libs might not work"
>     mv "${D}"/usr/lib32 "${D}"/usr/${x86_libdir} || die
>     mv "${D}"/lib32 "${D}"/${x86_libdir} || die
> fi

[Comment 5 SpanKY 2012-10-28 09:23:06 UTC]

(In reply to comment #4)

mmm, i meant $(get_abi_LIBDIR x86)

[Comment 6 Pacho Ramos 2012-10-28 09:44:00 UTC]

   28 Oct 2012; Pacho Ramos <[e-mail]> emul-linux-x86.eclass:
+  Do not hardcode lib32, bug #429726 by SpanKY.

[Comment 7 SpanKY 2012-11-02 16:38:45 UTC]

(In reply to comment #6)

i had to apply this fix:
http://sources.gentoo.org/eclass/emul-linux-x86.eclass?r1=1.13&r2=1.14

not all packages install /lib32

[Comment 8 Pacho Ramos 2012-11-05 20:39:52 UTC]

Fine, thanks for noticing!

[Comment 9 Steven Newbury 2013-10-13 19:55:41 UTC]

gx86 transition emul-linux-x86 packages aren't handling this:

emul-linux-x86-baselibs-20131008-r1 contains a list of native installed files in files/remove-native used to remove conflicts when use abi_x86_32.  Unfortunately, this list is hardcoded to lib32 so doesn't work with SYMLINK_LIB="no" LIBDIR_x86="lib".

The "cat" for reading remove-native should be changed to something like sed -e "s/@LIBDIR@/$(get_abi_LIBDIR x86)/g" with a @LIBDIR@ place-holder in the file list.

[Comment 10 Steven Newbury 2013-10-15 08:05:18 UTC]

I don't know what I was thinking, this is already handled by the eclass!  Sorry about the noise!

(I just needed to add a few more adopted packages to the list but used lib instead of lib32 in the remove-native list and proceeded to wander down a strange path)