Bug 429202 – Please stabilize =sys-apps/paxctl-0.7-r2

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Paweł Hajdan, Jr. (RETIRED) 2012-07-31 21:16:44 UTC]

Is it OK to stabilize =sys-apps/paxctl-0.7-r2 ?

If so, please CC all arches which have stable keywords

for older versions of this package and add STABLEREQ keyword

to the bug.

[Comment 1 Anthony Basile 2012-08-04 22:43:06 UTC]

go for it!

Target: alpha amd64 arm hppa ia64 ppc ppc64 s390 sh sparc x86

[Comment 2 Anthony Basile 2012-08-05 05:54:23 UTC]

Stable arm ppc pp64

[Comment 3 Johannes Huber (RETIRED) 2012-08-05 18:17:05 UTC]

x86 stable

[Comment 4 Agostino Sarubbo 2012-08-05 18:22:41 UTC]

@blueness, the syntax of the ebuild is bad.

DOCS=( ) does not install anything if there is not default in src_install.

This is a result of qlist:


# qlist paxctl
/usr/share/man/man1/paxctl.1.bz2
/sbin/paxctl

[Comment 5 Anthony Basile 2012-08-05 20:57:28 UTC]

(In reply to comment #4)
> @blueness, the syntax of the ebuild is bad.
> 
> DOCS=( ) does not install anything if there is not default in src_install.
> 
> This is a result of qlist:
> 
> 
> # qlist paxctl
> /usr/share/man/man1/paxctl.1.bz2
> /sbin/paxctl

Thanks ago.  This is a trivial fix.  Is it okay to just add the following and then continue with the same stabilization?

Index: paxctl-0.7-r2.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/sys-apps/paxctl/paxctl-0.7-r2.ebuild,v
retrieving revision 1.4
diff -u -B -r1.4 paxctl-0.7-r2.ebuild
--- paxctl-0.7-r2.ebuild	5 Aug 2012 05:53:06 -0000	1.4
+++ paxctl-0.7-r2.ebuild	5 Aug 2012 20:56:43 -0000
@@ -34,5 +34,6 @@
 }
 
 src_install () {
+	default
 	emake DESTDIR="${ED}" install
 }

[Comment 6 Agostino Sarubbo 2012-08-06 15:55:11 UTC]

(In reply to comment #5)
> (In reply to comment #4)
> > @blueness, the syntax of the ebuild is bad.
> > 
> > DOCS=( ) does not install anything if there is not default in src_install.
> > 
> > This is a result of qlist:
> > 
> > 
> > # qlist paxctl
> > /usr/share/man/man1/paxctl.1.bz2
> > /sbin/paxctl
> 
> Thanks ago.  This is a trivial fix.  Is it okay to just add the following
> and then continue with the same stabilization?
> 
> Index: paxctl-0.7-r2.ebuild
> ===================================================================
> RCS file: /var/cvsroot/gentoo-x86/sys-apps/paxctl/paxctl-0.7-r2.ebuild,v
> retrieving revision 1.4
> diff -u -B -r1.4 paxctl-0.7-r2.ebuild
> --- paxctl-0.7-r2.ebuild	5 Aug 2012 05:53:06 -0000	1.4
> +++ paxctl-0.7-r2.ebuild	5 Aug 2012 20:56:43 -0000
> @@ -34,5 +34,6 @@
>  }
>  
>  src_install () {
> +	default
>  	emake DESTDIR="${ED}" install
>  }

No, it'is still bad.

This is the default for src_install
http://dev.gentoo.org/~zmedico/portage/doc/ch05s03s05.html#package-ebuild-eapi-4-phases-src-install

So:
1)default + DOCS=( ) 
or 
2)emake DESTDIR="${ED}" install + dodoc and drop DOCS=()

[Comment 7 Anthony Basile 2012-08-06 23:20:10 UTC]

> 2)emake DESTDIR="${ED}" install + dodoc and drop DOCS=()

Okay it has to be this way to stay prefix friendly.  I committed the fix to the tree.  Please continue stabilizing.

[Comment 8 Agostino Sarubbo 2012-08-07 17:58:33 UTC]

amd64 stable

[Comment 9 Jeroen Roovers (RETIRED) 2012-08-09 13:06:04 UTC]

Stable for HPPA.

[Comment 10 Raúl Porcel (RETIRED) 2012-08-27 17:42:25 UTC]

alpha/ia64/s390/sh/sparc stable