Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 429092 - javatoolkit-0.3.0-r7 installs files in the wrong path
Summary: javatoolkit-0.3.0-r7 installs files in the wrong path
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Java (show other bugs)
Hardware: All Linux
: Normal major
Assignee: Java team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-31 20:05 UTC by PhobosK
Modified: 2012-08-01 21:36 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description PhobosK 2012-07-31 20:05:25 UTC
The new javatoolkit-0.3.0-r7 has a problem in installing the files in the wrong path... namely /""/....

The line 36:
install-scripts = "${EPREFIX}"/usr/$(get_libdir)/${PN}/bin

should be without the quotes:

install-scripts = ${EPREFIX}/usr/$(get_libdir)/${PN}/bin
Comment 1 Ralph Sennhauser (RETIRED) gentoo-dev 2012-07-31 20:52:25 UTC
Fixed. Thanks for the report.

*javatoolkit-0.3.0-r8 (31 Jul 2012)

  31 Jul 2012; Ralph Sennhauser <sera@gentoo.org> -javatoolkit-0.3.0-r7.ebuild,
  +javatoolkit-0.3.0-r8.ebuild:
  Don't quote EPRIFIX, Portage doesn't like it. Thanks to PhobosK
  <phobosk@fastmail.fm>. #429092


@dev-portage: Only Portage is affected. Shouldn't /""/ be normalized?
Comment 2 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2012-07-31 21:11:40 UTC
Given that the ebuild doesn't support ANY Gentoo Prefix platforms, I haven't a clue why you are even adding $EPREFIX to the ebuild.

That above point withstanding, it is legal for EPREFIX to contain spaces, take care.
Comment 3 Zac Medico gentoo-dev 2012-07-31 21:48:02 UTC
(In reply to comment #1)
> @dev-portage: Only Portage is affected. Shouldn't /""/ be normalized?

Well, it's none of Portage's business if a package installs strange directory names containing quotes. It seems that the real problem is that the setup.cfg interpreter does not remove those quotes like a shell would. According to python's configparser documentation, spaces are allowed in values, with no need for quoting:

http://docs.python.org/dev/library/configparser.html#supported-ini-file-structure
Comment 4 Ralph Sennhauser (RETIRED) gentoo-dev 2012-08-01 10:42:41 UTC
(In reply to comment #2)
> Given that the ebuild doesn't support ANY Gentoo Prefix platforms, I haven't
> a clue why you are even adding $EPREFIX to the ebuild.
> 

Keywords aren't the upper limit of what is allowed to be supported in an ebuild. If there are things that need to be fixed for use in Prefix please file bugs.

> That above point withstanding, it is legal for EPREFIX to contain spaces,
> take care.

repoman complained so I added the quotes last minute even if unnecessary here and only tested in Paludis afterwards. They were not only unnecessary but actually wrong. Usually stuff breaks in Paludis first. Bad luck.
Comment 5 Ralph Sennhauser (RETIRED) gentoo-dev 2012-08-01 10:44:05 UTC
(In reply to comment #3)
> (In reply to comment #1)
> > @dev-portage: Only Portage is affected. Shouldn't /""/ be normalized?
> 
> Well, it's none of Portage's business if a package installs strange
> directory names containing quotes. It seems that the real problem is that
> the setup.cfg interpreter does not remove those quotes like a shell would.
> According to python's configparser documentation, spaces are allowed in
> values, with no need for quoting:
> 
> http://docs.python.org/dev/library/configparser.html#supported-ini-file-
> structure

Thanks, well, there is this difference, one package manager passes it though a shell, the other not. If you think Portages behavior is desirable then we can close here.

Thanks again everyone.
Comment 6 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2012-08-01 14:47:00 UTC
(In reply to comment #4)
> (In reply to comment #2)
> > Given that the ebuild doesn't support ANY Gentoo Prefix platforms, I haven't
> > a clue why you are even adding $EPREFIX to the ebuild.
> > 
> 
> Keywords aren't the upper limit of what is allowed to be supported in an
> ebuild. If there are things that need to be fixed for use in Prefix please
> file bugs.

Well, that is my point, Ralph. There is nothing to be fixed in the ebuild for Gentoo Prefix because the ebuild doesn't need any Gentoo Prefix compat vars. If anything, we can argue that this bug wouldn't exist if you didn't try to be helpful :) So, thanks for being forward looking but there will be no bugs filed for Prefix support issues at this time.
 
> > That above point withstanding, it is legal for EPREFIX to contain spaces,
> > take care.
> 
> repoman complained so I added the quotes last minute even if unnecessary
> here and only tested in Paludis afterwards. They were not only unnecessary
> but actually wrong. Usually stuff breaks in Paludis first. Bad luck.

So, does this work:

    install-scripts = ${EPREFIX}/usr/$(get_libdir)/${PN}/bin

When EPREFIX is "/path/to/location here/" ?

IF not, I suggest you remove the EPREFIX var completely to avoid confusion that it was tested/supported.

I'm not CC'd to this bug, if you would like more help please CC prefix@g.o or ask. I'll probably forget to check up.
Comment 7 Ralph Sennhauser (RETIRED) gentoo-dev 2012-08-01 15:43:34 UTC
(In reply to comment #6)
> 
> So, does this work:
> 
>     install-scripts = ${EPREFIX}/usr/$(get_libdir)/${PN}/bin
> 
> When EPREFIX is "/path/to/location here/" ?
> 

Yes, will work as intended, whitespace is preserved. It's the same as with Java's properties files. 

> IF not, I suggest you remove the EPREFIX var completely to avoid confusion
> that it was tested/supported.
> 
> I'm not CC'd to this bug, if you would like more help please CC prefix@g.o
> or ask. I'll probably forget to check up.


I'm fine with the current solution, so unless you want something changed I see this as closed. Ie. the same as autotools based packages configure with ${EPREFIX} install to ${D}
Comment 8 Zac Medico gentoo-dev 2012-08-01 21:36:46 UTC
(In reply to comment #5)
> Thanks, well, there is this difference, one package manager passes it though
> a shell, the other not. If you think Portages behavior is desirable then we
> can close here.

That setup.cfg file should be parsed by distutils rather than the package manager, so it shouldn't make a difference what package manager you use.