Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 428468 - dev-lang/v8-9999: incorrect usage of GYPFLAGS on make command line
Summary: dev-lang/v8-9999: incorrect usage of GYPFLAGS on make command line
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Chromium Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-28 20:13 UTC by 5FBCDB43
Modified: 2012-07-30 06:37 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description 5FBCDB43 2012-07-28 20:13:19 UTC
The emake command in src_compile() has the variable GYPFLAGS as an argument.
The problem is that (on my box at least) the value passed as the argument is treated as the final value (it overwrites whatever the Makefile sets), which results in no shared library being built.

If you set the variable before make is executed then it's okay.

Reproducible: Always




Shell is zsh-5.0.0, make is 3.82-r3.
Comment 1 Mike Gilbert gentoo-dev 2012-07-28 20:29:57 UTC
You're right; GYPFLAGS is intended to be set in the environment, not as a command line argument.

Since it was only present in the live ebuild, I just removed it entirely.
Comment 2 Fabian Groffen gentoo-dev 2012-07-29 07:51:06 UTC
upstream told me to do it like that, but whatever
Comment 3 Mike Gilbert gentoo-dev 2012-07-29 15:44:49 UTC
That's weird advice. I really don't see how that could have worked, unless the Makefile changed.

Just let me know if you want to make another attempt at supporting prefix.
Comment 4 Fabian Groffen gentoo-dev 2012-07-30 06:37:52 UTC
s/prefix/macosx without targetting an ancient ABI/.

Sorry for breaking the builds here, I think I can live with it doing stupid things.  I hope I can move rails away from using v8, since it's a can of worms that needs to be avoided like pest anyway.