Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 428316 - games-rpg/mana-0.6.1: fails to build
Summary: games-rpg/mana-0.6.1: fails to build
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Julian Ospald
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-27 13:46 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2013-07-29 21:25 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,49.30 KB, text/plain)
2012-07-27 13:55 UTC, Julian Ospald
Details
mana-0.6.1.ebuild.diff (mana-0.6.1.ebuild.diff,505 bytes, patch)
2012-07-27 20:45 UTC, Julian Ospald
Details | Diff
mana-0.6.1-gcc-4.7.patch (mana-0.6.1-gcc-4.7.patch,1.93 KB, patch)
2012-07-27 20:45 UTC, Julian Ospald
Details | Diff
build.log with #include <cstdlib> (build.log,25.93 KB, text/plain)
2012-07-27 20:53 UTC, Julian Ospald
Details
build log with #include <cstdint> (build.log,203.76 KB, text/plain)
2012-07-28 07:57 UTC, Julian Ospald
Details
mana-0.6.1.ebuild.diff (mana-0.6.1.ebuild.diff,729 bytes, patch)
2012-07-28 14:17 UTC, Julian Ospald
Details | Diff
mana-0.6.1-Fix-missing-virtual-destructors-and-guichan-use.patch (mana-0.6.1-Fix-missing-virtual-destructors-and-guichan-use.patch,1.60 KB, patch)
2012-07-28 14:17 UTC, Julian Ospald
Details | Diff
mana-0.6.1-Trick-gcc-into-importing-C99-stdint.h-when-C-11-is-n.patch (mana-0.6.1-Trick-gcc-into-importing-C99-stdint.h-when-C-11-is-n.patch,653 bytes, patch)
2012-07-28 14:17 UTC, Julian Ospald
Details | Diff
mana-0.6.1-Import-cstdint-for-int64_t.patch (mana-0.6.1-Import-cstdint-for-int64_t.patch,592 bytes, patch)
2012-07-28 14:18 UTC, Julian Ospald
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2012-07-27 13:46:09 UTC
Portage 2.2.0_alpha120 (default/linux/amd64/10.0, gcc-4.7.1-asneeded, glibc-2.16.0, 3.4.4-hardened-r1 x86_64)
=================================================================
System uname: Linux-3.4.4-hardened-r1-x86_64-AMD_Opteron-TM-_Processor_6272-with-gentoo-2.1
Timestamp of tree: Mon, 23 Jul 2012 14:30:01 +0000
ccache version 3.1.7 [disabled]
app-shells/bash:          4.2_p37
dev-java/java-config:     2.1.12
dev-lang/python:          2.6.8, 2.7.3-r2, 3.2.3-r1
dev-util/ccache:          3.1.7
dev-util/cmake:           2.8.8-r3
sys-apps/baselayout:      2.1-r1
sys-apps/openrc:          0.10.5
sys-apps/sandbox:         2.6
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.4_p6-r1, 1.9.6-r3, 1.10.3, 1.11.6, 1.12.2
sys-devel/binutils:       2.22-r1
sys-devel/gcc:            4.5.4, 4.6.3, 4.7.1
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4.2
sys-devel/make:           3.82-r3
sys-kernel/linux-headers: 3.5 (virtual/os-headers)
sys-libs/glibc:           2.16.0
Repositories: gentoo tbamd64
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -ggdb -march=native -ftracer -frecord-gcc-switches"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /etc/entropy /opt/openjms/config /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/maven-bin-3.0/conf /usr/share/openvpn/easy-rsa /usr/share/qpsmtpd/plugins /usr/share/themes/oxygen-gtk/gtk-2.0 /var/bind /var/lib/hsqldb /var/lib/redmine/config /var/spool/torque"
CONFIG_PROTECT_MASK="${EPREFIX}/etc/gconf /etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/games/angband/edit/ /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.3/ext-active/ /etc/php/apache2-php5.4/ext-active/ /etc/php/cgi-php5.3/ext-active/ /etc/php/cgi-php5.4/ext-active/ /etc/php/cli-php5.3/ext-active/ /etc/php/cli-php5.4/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/splash /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c /var/lib/redmine/config/locales /var/lib/redmine/config/settings.yml"
CXXFLAGS="-O2 -pipe -ggdb -march=native -ftracer -frecord-gcc-switches"
DISTDIR="/var/cache/portage/distfiles"
FCFLAGS="-O2 -pipe -ggdb -march=native -frecord-gcc-switches"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fail-clean fixlafiles news parallel-fetch parse-eapi-ebuild-head protect-owned sandbox sfperms strict test test-fail-continue unknown-features-warn unmerge-orphans userfetch userpriv usersandbox"
FFLAGS="-O2 -pipe -ggdb -march=native -frecord-gcc-switches"
GENTOO_MIRRORS="http://ftp.ucsb.edu/pub/mirrors/linux/gentoo/ http://gentoo.mirrors.hoobly.com/ http://gentoo.llarian.net/"
LANG="en_US.utf8"
LC_ALL="C"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j24"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/tmp"
PORTDIR="/var/cache/tinderbox/tree"
PORTDIR_OVERLAY="/root/overlay"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="3dnow 3dnowex acl amd64 berkdb bzip2 cli cracklib crypt cups cxx dri emacs ffmpeg fortran gdbm gnutls gphoto gphoto2 gpm iconv ipv6 mmx modules mudflap multilib ncurses nls nptl openmp pam pax_kernel pcre pdf plasma pppd qt3support readline semantic-desktop session sse sse2 sse3 sse4 ssl ssse3 tcmalloc tcpd udev unicode vhosts xorg zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" PHP_TARGETS="php5-3" PYTHON_TARGETS="python3_2 python2_7" RUBY_TARGETS="ruby18 ruby19 ree18" USERLAND="GNU" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LINGUAS, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
Comment 1 Julian Ospald 2012-07-27 13:55:44 UTC
Created attachment 319416 [details]
build.log
Comment 2 Julian Ospald 2012-07-27 20:45:16 UTC
Created attachment 319450 [details, diff]
mana-0.6.1.ebuild.diff
Comment 3 Julian Ospald 2012-07-27 20:45:34 UTC
Created attachment 319452 [details, diff]
mana-0.6.1-gcc-4.7.patch
Comment 4 Diego Elio Pettenò (RETIRED) gentoo-dev 2012-07-27 20:47:44 UTC
Patch is NAK in my opinion.

You just need to

#include <cstdint>

instead of messing with default typedefs.
Comment 5 Julian Ospald 2012-07-27 20:51:25 UTC
(In reply to comment #4)
> Patch is NAK in my opinion.
> 
> You just need to
> 
> #include <cstdint>
> 
> instead of messing with default typedefs.

that is incorrect.
Comment 6 Julian Ospald 2012-07-27 20:53:32 UTC
Created attachment 319454 [details]
build.log with #include <cstdlib>
Comment 7 Julian Ospald 2012-07-27 20:55:34 UTC
otherwise please provide a patch if I misunderstood you
Comment 8 Diego Elio Pettenò (RETIRED) gentoo-dev 2012-07-27 20:56:34 UTC
Okay so it's either shaded by some language define or something like that, but using typedef for the default types is _not_ a good idea.
Comment 9 Julian Ospald 2012-07-27 20:57:45 UTC
(In reply to comment #8)
> Okay so it's either shaded by some language define or something like that,
> but using typedef for the default types is _not_ a good idea.

would you care to comment here then?

https://github.com/mana/mana/commit/86154175f63a7f1a4b73b3727314ac760d83834e#diff-0

otherwise I think going with upstream patches is what I would prefer.
Comment 10 Julian Ospald 2012-07-28 07:08:49 UTC
what also works is:

use the patch except the "src/cpp0x_compat/cstdint" part, compile dev-games/guichan with "-std=c++0x" and recompile games-rpg/mana with "-DENABLE_CPP0X=ON"
Comment 11 Julian Ospald 2012-07-28 07:57:19 UTC
Created attachment 319498 [details]
build log with #include <cstdint>

The build log was actually the wrong one.

Here we get linker errors with the same patch + the following ebuild-line:
echo 'extern "C" { #include <stdint.h> }' > src/cpp0x_compat/cstdint

They do not occur if dev-games/guichan was also built with -std=c++0x as previously mentioned.
Comment 12 Julian Ospald 2012-07-28 14:17:08 UTC
Created attachment 319516 [details, diff]
mana-0.6.1.ebuild.diff
Comment 13 Julian Ospald 2012-07-28 14:17:40 UTC
Created attachment 319518 [details, diff]
mana-0.6.1-Fix-missing-virtual-destructors-and-guichan-use.patch
Comment 14 Julian Ospald 2012-07-28 14:17:55 UTC
Created attachment 319520 [details, diff]
mana-0.6.1-Trick-gcc-into-importing-C99-stdint.h-when-C-11-is-n.patch
Comment 15 Julian Ospald 2012-07-28 14:18:10 UTC
Created attachment 319522 [details, diff]
mana-0.6.1-Import-cstdint-for-int64_t.patch
Comment 16 Julian Ospald 2012-07-28 14:22:10 UTC
sry for this mess, but these patches by mgorny work with "-DENABLE_CPP0X=OFF" in the ebuild for both gcc-4.7 and gcc-4.5

all files updated, any objections?
Comment 17 Diego Elio Pettenò (RETIRED) gentoo-dev 2012-07-28 15:16:58 UTC
LMBTM

(Looks Much Better To Me)
Comment 18 Julian Ospald 2012-07-28 16:10:25 UTC
(In reply to comment #17)
> LMBTM
> 
> (Looks Much Better To Me)

It seems mana upstream is considering to go c++11 all the way which would mean we have to force c++11 for dev-games/guichan too.

I would propose to do that via a revbump, then we don't even need that patch. Should we care about breakage of gcc-4.2?...
Comment 19 Julian Ospald 2012-07-28 16:13:31 UTC
or via useflag... opinions?
Comment 20 Julian Ospald 2012-08-05 12:07:25 UTC
I will wait until this pull request is resolved:

https://github.com/mana/mana/pull/16
Comment 21 Julian Ospald 2013-07-29 21:25:55 UTC
+ 29 Jul 2013; Julian Ospald <hasufell@gentoo.org> mana-0.6.1.ebuild,
+ +files/mana-0.6.1-Fix-missing-virtual-destructors-and-guichan-use.patch,
+ +files/mana-0.6.1-Import-cstdint-for-int64_t.patch,
+ +files/mana-0.6.1-Trick-gcc-into-importing-C99-stdint.h-when-C-11-is-n.patch:
+ fix bug 428316