Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 428186 - app-admin/gtkdiskfree-2.0.1: ignores cflags
Summary: app-admin/gtkdiskfree-2.0.1: ignores cflags
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Samuel Bauer
URL: https://tinderboxlogs.s3.amazonaws.co...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-26 14:07 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2012-08-12 21:01 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2012-07-26 14:07:26 UTC
Portage 2.2.0_alpha120 (default/linux/amd64/10.0, gcc-4.7.1-asneeded, glibc-2.16.0, 3.4.4-hardened-r1 x86_64)
=================================================================
System uname: Linux-3.4.4-hardened-r1-x86_64-AMD_Opteron-TM-_Processor_6272-with-gentoo-2.1
Timestamp of tree: Mon, 23 Jul 2012 14:30:01 +0000
ccache version 3.1.7 [disabled]
app-shells/bash:          4.2_p37
dev-java/java-config:     2.1.12
dev-lang/python:          2.6.8, 2.7.3-r2, 3.2.3-r1
dev-util/ccache:          3.1.7
dev-util/cmake:           2.8.8-r3
sys-apps/baselayout:      2.1-r1
sys-apps/openrc:          0.10.5
sys-apps/sandbox:         2.6
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.4_p6-r1, 1.9.6-r3, 1.10.3, 1.11.6, 1.12.2
sys-devel/binutils:       2.22-r1
sys-devel/gcc:            4.5.4, 4.6.3, 4.7.1
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4.2
sys-devel/make:           3.82-r3
sys-kernel/linux-headers: 3.5 (virtual/os-headers)
sys-libs/glibc:           2.16.0
Repositories: gentoo tbamd64
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -ggdb -march=native -ftracer -frecord-gcc-switches"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /etc/entropy /opt/openjms/config /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/maven-bin-3.0/conf /usr/share/openvpn/easy-rsa /usr/share/qpsmtpd/plugins /usr/share/themes/oxygen-gtk/gtk-2.0 /var/bind /var/lib/hsqldb /var/lib/redmine/config /var/spool/torque"
CONFIG_PROTECT_MASK="${EPREFIX}/etc/gconf /etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/games/angband/edit/ /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.3/ext-active/ /etc/php/apache2-php5.4/ext-active/ /etc/php/cgi-php5.3/ext-active/ /etc/php/cgi-php5.4/ext-active/ /etc/php/cli-php5.3/ext-active/ /etc/php/cli-php5.4/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/splash /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c /var/lib/redmine/config/locales /var/lib/redmine/config/settings.yml"
CXXFLAGS="-O2 -pipe -ggdb -march=native -ftracer -frecord-gcc-switches"
DISTDIR="/var/cache/portage/distfiles"
FCFLAGS="-O2 -pipe -ggdb -march=native -frecord-gcc-switches"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fail-clean fixlafiles news parallel-fetch parse-eapi-ebuild-head protect-owned sandbox sfperms strict test test-fail-continue unknown-features-warn unmerge-orphans userfetch userpriv usersandbox"
FFLAGS="-O2 -pipe -ggdb -march=native -frecord-gcc-switches"
GENTOO_MIRRORS="http://ftp.ucsb.edu/pub/mirrors/linux/gentoo/ http://gentoo.mirrors.hoobly.com/ http://gentoo.llarian.net/"
LANG="en_US.utf8"
LC_ALL="C"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j24"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/tmp"
PORTDIR="/var/cache/tinderbox/tree"
PORTDIR_OVERLAY="/root/overlay"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="3dnow 3dnowex acl amd64 berkdb bzip2 cli cracklib crypt cups cxx dri emacs ffmpeg fortran gdbm gnutls gphoto gphoto2 gpm iconv ipv6 mmx modules mudflap multilib ncurses nls nptl openmp pam pax_kernel pcre pdf plasma pppd qt3support readline semantic-desktop session sse sse2 sse3 sse4 ssl ssse3 tcmalloc tcpd udev unicode vhosts xorg zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" PHP_TARGETS="php5-3" PYTHON_TARGETS="python3_2 python2_7" RUBY_TARGETS="ruby18 ruby19 ree18" USERLAND="GNU" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LINGUAS, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
Comment 1 Samuel Bauer 2012-07-26 19:31:47 UTC
Thanks for this report, I'll soon fix it in the repository.

For the ebuild itself:
sed -i "s/-Wall -O2/${CFLAGS}/" configure
Should do the job.

I didn't agreed to be proxy-maintainer of this ebuild unless it has a suitable* way to build using gtk2, even defaulting to gtk3

*EXTRA_ECONF seems to me a trick more than a suitable way
Comment 2 Michael Weber (RETIRED) gentoo-dev 2012-07-26 20:46:02 UTC
(In reply to comment #1)
> I didn't agreed to be proxy-maintainer of this ebuild unless it has a
> suitable* way to build using gtk2, even defaulting to gtk3

I've looked into /usr/portage/profile/use.{,local}.desc and decided to add
USE gtk3 to switch from gtk2 to 3. That's the only behaviour I could see there.

Samuel, can you agree on this or should I remove you as proxied-maintainer?

Michael

p.s. I decided to commit below change with stable keywords for amd64/x86 (i.e. not doing an revump) intentionally. I've tested it.

Index: gtkdiskfree-2.0.1.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/app-admin/gtkdiskfree/gtkdiskfree-2.0.1.ebuild,v
retrieving revision 1.5
diff -u -B -r1.5 gtkdiskfree-2.0.1.ebuild
--- gtkdiskfree-2.0.1.ebuild    6 Jun 2012 08:03:41 -0000       1.5
+++ gtkdiskfree-2.0.1.ebuild    26 Jul 2012 20:41:05 -0000
@@ -4,6 +4,8 @@
 
 EAPI=4
 
+inherit autotools
+
 DESCRIPTION="Graphical tool to show free disk space"
 HOMEPAGE="https://gitorious.org/gtkdiskfree"
 SRC_URI="mirror://gentoo/${P}.tar.gz"
@@ -11,15 +13,25 @@
 LICENSE="GPL-2"
 SLOT="0"
 KEYWORDS="amd64 ~ia64 ~ppc ~ppc64 ~sparc x86"
-IUSE="nls"
+IUSE="gtk3 nls"
 
-RDEPEND="x11-libs/gtk+:3"
+RDEPEND="gtk3? ( x11-libs/gtk+:3 )
+       !gtk3? ( x11-libs/gtk+:3 )"
 DEPEND="${RDEPEND}
        virtual/pkgconfig
        nls? ( sys-devel/gettext )"
 
 S=${WORKDIR}/${PN}-master
 
+src_prepare() {
+       sed -e '/^CFLAGS=/s:=" -Wall -O2 :+=" :' \
+               -i configure.in || die
+       eautoreconf
+}
+
 src_configure() {
-       econf $(use_enable nls) --without-gtk2
+       local my_econf="--with-gtk2"
+       use gtk3 && my_econf="--without-gtk2"
+       econf $(use_enable nls) \
+               ${my_econf}
 }
Comment 3 Michael Weber (RETIRED) gentoo-dev 2012-07-26 20:47:20 UTC
+  26 Jul 2012; Michael Weber <xmw@gentoo.org> gtkdiskfree-2.0.1.ebuild,
+  metadata.xml:
+  Fix CFLAGS, add USE gtk3 (bug 428186)
+
Comment 4 Samuel Bauer 2012-07-27 05:10:37 UTC
Important point is that one should be able to compile using his preference. Transition should be soft, sharp way and masking compile option seems to me quite awful as gentoo is supposed to be at the opposite of this. (There's already plenty of distribution where everything is "static" and imposed by devellopers).

As gtk3 flag allow users to use gtk2, I totally agree on proxy maintaining the ebuild.

P.S.: I know it's not the subject here but why not still offering to compile what can be with gtk2, whilst officially only supporting gtk3 (masked flags for gtk2 seems appropriate). This would reduce complexity for maintaining ebuild.
Comment 5 Samuel Bauer 2012-08-12 21:01:54 UTC
Sorry I didn't red carefully the patch from Comment 2:

-RDEPEND="x11-libs/gtk+:3"
+RDEPEND="gtk3? ( x11-libs/gtk+:3 )
+       !gtk3? ( x11-libs/gtk+:3 )"

gtk3 should be installed "by any means necessary"
Hope that's not part of any conspiracy